Skip to content

refactor: remove dead print format#54655

Open
iamejaaz wants to merge 1 commit intofrappe:developfrom
iamejaaz:remove-sales-print
Open

refactor: remove dead print format#54655
iamejaaz wants to merge 1 commit intofrappe:developfrom
iamejaaz:remove-sales-print

Conversation

@iamejaaz
Copy link
Copy Markdown
Member

Since there is a new print format for the Sales Invoice, this is no longer needed and is also outdated.

@iamejaaz iamejaaz requested a review from ruthra-kumar as a code owner April 29, 2026 16:07
@github-actions github-actions Bot added needs-tests This PR needs automated unit-tests. skip-release-notes This PR should not be mentioned in the release notes labels Apr 29, 2026
@iamejaaz iamejaaz removed the needs-tests This PR needs automated unit-tests. label Apr 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 147b78e5-b38b-4aae-8e14-3029f0a94e53

📥 Commits

Reviewing files that changed from the base of the PR and between a04c028 and c933c2b.

📒 Files selected for processing (3)
  • erpnext/accounts/print_format/sales_invoice_print/__init__.py
  • erpnext/accounts/print_format/sales_invoice_print/sales_invoice_print.html
  • erpnext/accounts/print_format/sales_invoice_print/sales_invoice_print.json
💤 Files with no reviewable changes (2)
  • erpnext/accounts/print_format/sales_invoice_print/sales_invoice_print.html
  • erpnext/accounts/print_format/sales_invoice_print/sales_invoice_print.json

📝 Walkthrough

Walkthrough

This pull request removes the "Sales Invoice Print" print format by deleting its two constituent files: the HTML template file containing the Jinja2-based invoice rendering logic and the JSON configuration file defining the format metadata. The template included header, items table, tax calculations, and terms sections. The removal eliminates the complete print format definition from the codebase.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor: remove dead print format' accurately summarizes the main change—removal of an outdated print format file.
Description check ✅ Passed The description explains the rationale for removing the print format, citing the existence of a new print format and that the old one is outdated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@iamejaaz iamejaaz added backport version-16-hotfix and removed skip-release-notes This PR should not be mentioned in the release notes labels Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.74%. Comparing base (2b3e047) to head (c933c2b).
⚠️ Report is 37 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #54655      +/-   ##
===========================================
+ Coverage    79.44%   79.74%   +0.30%     
===========================================
  Files         1160     1160              
  Lines       126161   126380     +219     
===========================================
+ Hits        100224   100781     +557     
+ Misses       25937    25599     -338     

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant