Skip to content

fix(profit-loss-report): handle zero base values and prevent null% display #54684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AhmedAbokhatwa wants to merge 3 commits into
base: develop
Choose a base branch
from
+11 −3
Open

fix(profit-loss-report): handle zero base values and prevent null% display #54684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df6fd78
fix(profit-and-loss-statement-report): margin calculation the report …
AhmedAbokhatwa Apr 30, 2026
671555e
fix(profit-and-loss-statement): margin calculation the report showing…
AhmedAbokhatwa Apr 30, 2026
7335011
fix(profit-loss-report): handle zero base values and prevent null% di…
AhmedAbokhatwa Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions erpnext/accounts/report/financial_statements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,13 +785,21 @@ def compute_margin_view_data(data, columns, accumulated_values):

for column in columns:
curr_period = column.get("key")
base_value = base_row[curr_period]
curr_value = row[curr_period]

if curr_value is None or base_value <= 0:
base_value = base_row.get(curr_period)
curr_value = row.get(curr_period)

if base_value is None or curr_value is None:
data[row_idx][curr_period] = None
continue

if base_value == 0:
if curr_value == 0:
data[row_idx][curr_period] = 0
else:
data[row_idx][curr_period] = None
continue

margin_percent = round((curr_value / base_value) * 100, 2)

data[row_idx][curr_period] = margin_percent
Loading