ISSUE-7275: Staging job should use pre-built deb packages - #7819
Draft
herbenderbler wants to merge 1 commit into
Draft
ISSUE-7275: Staging job should use pre-built deb packages#7819herbenderbler wants to merge 1 commit into
herbenderbler wants to merge 1 commit into
Conversation
herbenderbler
marked this pull request as draft
April 28, 2026 15:58
Update staging CI to prioritize reusing Package builds artifacts for the current SHA, wait for in-flight build runs before fallback, and ensure staging branches trigger package builds.
herbenderbler
force-pushed
the
ISSUE-7275/fix-staging-job
branch
from
April 28, 2026 16:19
efe70f8 to
8e7e65d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Staging no longer builds debs on the GCE host. It reuses the artifact from the
latest successful Package builds run for the current commit, and falls back
to building on a GitHub-hosted runner only when no run exists for that SHA.
Supersedes #7798 to use the corrected branch name.
Implementation Details
.github/workflows/build-debs-reusable.ymlbuilds noble debs (server,OSSEC, app-code, config, keyring, admin) plus a trixie-built
securedrop-admin. The trixie variant is required because the GCE host istrixie and the staging converge invokes
securedrop-admin generate_v3_keyson
localhost(roles/tor-hidden-services); the admin deb's bundled venvis ABI-tied to its builder image's Python. Artifact ships
build/noble/andbuild/trixie/..github/workflows/build.ymlnow calls the reusable workflow;reproducible-debsupdated for the new layout and adds the trixie admindeb to its diffoscope check.
.github/workflows/staging.ymladdsresolve-debs(usesgh run list/gh run downloadto grabnoble-onefor the SHA) and a fallbackbuild-debsjob; thestagingjob downloadsstaging-debs-nobleintobuild/and exportsCI_PREBUILT_DEBS=1. Drops the priorworkflow_dispatchopt-in toggle now that strict reuse is the default.devops/gce-nested/gce-runner.shrsyncs both deb subdirs to GCE, skipson-host
make build-debs-*underCI_PREBUILT_DEBS=1, restoresapt-get updatebefore installing, and installs the trixie admin debunconditionally.
admin/bin/validate-gpg-key.sh:SC2329shellcheck disable for thetrap-invoked cleanup function (false positive on newer shellcheck).
Checklist
no new app/locked dependencies.