[WEB-718] feat: add offset implementation for firestore - #145
Merged
Conversation
BaDo2001
enabled auto-merge
April 21, 2026 11:42
auto-merge was automatically disabled
April 21, 2026 11:49
Pull request was closed
LukeInkster
reviewed
Apr 21, 2026
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [12.x, 14.x, 16.x, 18.x] |
There was a problem hiding this comment.
What's the reason for removing the old versions here? Looks like the pipeline is still looking for them to have passed
Contributor
Author
There was a problem hiding this comment.
Readded them for the pipeline to pass, I'm not sure when to change that. 🤔 I removed initially because we are not using those versions anywhere anymore.
BaDo2001
enabled auto-merge
April 21, 2026 12:05
LukeInkster
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation for offset method