fix(windows): encode SSID on xml generation#148
Open
is-equal wants to merge 142 commits into
Open
Conversation
Cannot read property '1' of null fixed.
# Conflicts: # src/windows-connect.js
Wait until device is connected, delete profile if connection fails
I was having problems to connect to a network using my 2nd wi-fi interface on Windows 10. I executed the command manualy and the error seemed to be a missing argument. Than noticed that passing the `interface="intf"` argument, the command works. I think it's because I have more than one interfaces connected to my pc, so you have to tell `netsh` what interface I want to use.
… rodrigogs-patch-2
- remove global installation of npx to avoid conflicts - fix commitlint
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. <details> <summary>Changelog</summary> *Sourced from [handlebars's changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md).* > ## v4.5.3 - November 18th, 2019 > Bugfixes: > > - fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7 > - fix: add more properties required to be enumerable - 1988878 > > Chores / Build: > - fix: use !== 0 instead of != 0 - c02b05f > - add chai and dirty-chai and sinon, for cleaner test-assertions and spies, > deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0 > > Security: > > - The properties `__proto__`, `__defineGetter__`, `__defineSetter__` and `__lookupGetter__` > have been added to the list of "properties that must be enumerable". > If a property by that name is found and not enumerable on its parent, > it will silently evaluate to `undefined`. This is done in both the compiled template and the "lookup"-helper. > This will prevent new Remote-Code-Execution exploits that have been > published recently. > > Compatibility notes: > > - Due to the security-fixes. The semantics of the templates using > `__proto__`, `__defineGetter__`, `__defineSetter__` and `__lookupGetter__` in the respect that those expression now return > `undefined` rather than their actual value from the proto. > - The semantics have not changed in cases where the properties are enumerable, as in: > > ```js > { > __proto__: 'some string' > } > ``` > > - The change may be breaking in that respect, but we still only > increase the patch-version, because the incompatible use-cases > are not intended, undocumented and far less important than fixing > Remote-Code-Execution exploits on existing systems. > > > > [Commits](handlebars-lang/handlebars.js@v4.5.2...v4.5.3) > > ## v4.5.2 - November 13th, 2019 > # Bugfixes > > - fix: use String(field) in lookup when checking for "constructor" - d541378 > - test: add fluent API for testing Handlebars - c2ac79c > > Compatibility notes: > - no incompatibility are to be expected ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`c819c8b`](handlebars-lang/handlebars.js@c819c8b) v4.5.3 - [`827c9d0`](handlebars-lang/handlebars.js@827c9d0) Update release notes - [`f7f05d7`](handlebars-lang/handlebars.js@f7f05d7) fix: add "no-prototype-builtins" eslint-rule and fix all occurences - [`1988878`](handlebars-lang/handlebars.js@1988878) fix: add more properties required to be enumerable - [`886ba86`](handlebars-lang/handlebars.js@886ba86) test/chore: add chai/expect and sinon to "runtime"-environment - [`0817dad`](handlebars-lang/handlebars.js@0817dad) test: add sinon as global variable to eslint in the specs - [`93516a0`](handlebars-lang/handlebars.js@93516a0) test: add sinon.js for spies, deprecate current assertions - [`93e284e`](handlebars-lang/handlebars.js@93e284e) chore: add chai and dirty-chai for better test assertions - [`c02b05f`](handlebars-lang/handlebars.js@c02b05f) fix: use !== 0 instead of != 0 - [`8de121d`](handlebars-lang/handlebars.js@8de121d) v4.5.2 - Additional commits viewable in [compare view](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/friedrith/node-wifi/network/alerts). </details>
Bumps [acorn](https://github.com/acornjs/acorn) from 6.2.0 to 6.4.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li> <li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce351b54f956e2c4ed27cca9631284"><code>90a9548</code></a> More rigorously check surrogate pairs in regexp validator</li> <li><a href="https://github.com/acornjs/acorn/commit/df0cf1a3e2b1a51a26c14984dc0f5412b7151b10"><code>df0cf1a</code></a> Mark version 6.4.0</li> <li><a href="https://github.com/acornjs/acorn/commit/53034126864b492da4e278628bb972cb2a9313d4"><code>5303412</code></a> Also export Parser via Parser.acorn</li> <li><a href="https://github.com/acornjs/acorn/commit/efe273e70123449a458157dbf578afaf109a49ab"><code>efe273e</code></a> give token types and etc to plugins</li> <li><a href="https://github.com/acornjs/acorn/commit/ac6decb94a3aa4eee99230fdaf5883dfaafe8479"><code>ac6decb</code></a> Mark version 6.3.0</li> <li><a href="https://github.com/acornjs/acorn/commit/7e9817d17639d95cc6dbacfde734a0626b2a7dea"><code>7e9817d</code></a> Allow sourceType: module even with ecmaVersion < 6</li> <li><a href="https://github.com/acornjs/acorn/commit/e2b8cc087386eccc2ad6fd4a02b4257833557cb3"><code>e2b8cc0</code></a> Fix broken parsing of new expressions when allowReserved=="never"</li> <li><a href="https://github.com/acornjs/acorn/commit/1555c528855b10320ce98b4154906d7898c92990"><code>1555c52</code></a> Update acorn.d.ts</li> <li><a href="https://github.com/acornjs/acorn/commit/77c20fa2c2f490e646b67e6a0ff7e75fb54ab6c8"><code>77c20fa</code></a> Mark version 6.2.1</li> <li>Additional commits viewable in <a href="https://github.com/acornjs/acorn/compare/6.2.0...6.4.1">compare view</a></li> </ul> </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/friedrith/node-wifi/network/alerts). </details>
Rename command `prettier` to make it higher level.
- split the function to scan networks on macos to simplify tests. - add a command `npm run test`
A line was shifted in airport output (cf scan-shifted.log) and it was breaking parser for this line. It is now fixed
Rewrite wifi binary to make it compliant with ES6.
- split macOS connection like macOS scan to simplify tests - fix db/percentage conversion - refactor frequency/channel conversion
- add github action to test - remove travis build config
…#125) Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 8.0.0 to 8.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/conventional-changelog/standard-version/releases">standard-version's releases</a>.</em></p> <blockquote> <h2>standard-version v8.0.1</h2> <h3>Bug Fixes</h3> <ul> <li><strong>deps:</strong> update dependency conventional-changelog to v3.1.21 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/586">#586</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/fd456c995f3f88497fbb912fb8aabb8a42d97dbb">fd456c9</a>)</li> <li><strong>deps:</strong> update dependency conventional-changelog-conventionalcommits to v4.3.0 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/587">#587</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/b3b5eedea3eaf062d74d1004a55a0a6b1e3ca6c6">b3b5eed</a>)</li> <li><strong>deps:</strong> update dependency conventional-recommended-bump to v6.0.9 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/588">#588</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/d4d2ac2a99c095227118da795e1c9e19d06c9a0a">d4d2ac2</a>)</li> <li><strong>deps:</strong> update dependency git-semver-tags to v4 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/589">#589</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/a0f0e813b2be4a2065600a19075fda4d6f331ef8">a0f0e81</a>)</li> <li>Vulnerability Report GHSL-2020-11101 (<a href="https://www.github.com/conventional-changelog/standard-version/commit/9d978ac9d4f64be4c7b9d514712ab3757732d561">9d978ac</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md">standard-version's changelog</a>.</em></p> <blockquote> <h3><a href="https://www.github.com/conventional-changelog/standard-version/compare/v8.0.0...v8.0.1">8.0.1</a> (2020-07-12)</h3> <h3>Bug Fixes</h3> <ul> <li><strong>deps:</strong> update dependency conventional-changelog to v3.1.21 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/586">#586</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/fd456c995f3f88497fbb912fb8aabb8a42d97dbb">fd456c9</a>)</li> <li><strong>deps:</strong> update dependency conventional-changelog-conventionalcommits to v4.3.0 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/587">#587</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/b3b5eedea3eaf062d74d1004a55a0a6b1e3ca6c6">b3b5eed</a>)</li> <li><strong>deps:</strong> update dependency conventional-recommended-bump to v6.0.9 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/588">#588</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/d4d2ac2a99c095227118da795e1c9e19d06c9a0a">d4d2ac2</a>)</li> <li><strong>deps:</strong> update dependency git-semver-tags to v4 (<a href="https://www.github-redirect.dependabot.com/conventional-changelog/standard-version/issues/589">#589</a>) (<a href="https://www.github.com/conventional-changelog/standard-version/commit/a0f0e813b2be4a2065600a19075fda4d6f331ef8">a0f0e81</a>)</li> <li>Vulnerability Report GHSL-2020-11101 (<a href="https://www.github.com/conventional-changelog/standard-version/commit/9d978ac9d4f64be4c7b9d514712ab3757732d561">9d978ac</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/conventional-changelog/standard-version/commit/57e4e25d83552d225cf96e1dfc50e6042a2f7f6c"><code>57e4e25</code></a> chore: release 8.0.1 (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/611">#611</a>)</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/58105e126fd4392b5b23246a90a8c51a05ffded7"><code>58105e1</code></a> chore: Adds basic issue templates (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/613">#613</a>)</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/9d978ac9d4f64be4c7b9d514712ab3757732d561"><code>9d978ac</code></a> fix: Vulnerability Report GHSL-2020-11101</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/267d78dcb3bef90ad4dcbbafd2e77739efacdf37"><code>267d78d</code></a> chore: stop pinning deps (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/615">#615</a>)</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/da84ec4b44f7d45c3e06a93e24b17ee43b988992"><code>da84ec4</code></a> test(windows): skip mock-git tests for Windows (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/616">#616</a>)</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/871201ff8de6091d4b9b2ce9bf8611a1fc2f7836"><code>871201f</code></a> Merge pull request from GHSA-7xcx-6wjh-7xp2</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/a0f0e813b2be4a2065600a19075fda4d6f331ef8"><code>a0f0e81</code></a> fix(deps): update dependency git-semver-tags to v4 (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/589">#589</a>)</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/fd456c995f3f88497fbb912fb8aabb8a42d97dbb"><code>fd456c9</code></a> fix(deps): update dependency conventional-changelog to v3.1.21 (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/586">#586</a>)</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/b3b5eedea3eaf062d74d1004a55a0a6b1e3ca6c6"><code>b3b5eed</code></a> fix(deps): update dependency conventional-changelog-conventionalcommits to v4...</li> <li><a href="https://github.com/conventional-changelog/standard-version/commit/d4d2ac2a99c095227118da795e1c9e19d06c9a0a"><code>d4d2ac2</code></a> fix(deps): update dependency conventional-recommended-bump to v6.0.9 (<a href="https://github-redirect.dependabot.com/conventional-changelog/standard-version/issues/588">#588</a>)</li> <li>Additional commits viewable in <a href="https://github.com/conventional-changelog/standard-version/compare/v8.0.0...v8.0.1">compare view</a></li> </ul> </details> <br /> [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/friedrith/node-wifi/network/alerts). </details>
For a better readibility in pull requests, the workflow is now renamed "test" and is splited in two jobs: lint and unit tests
Split delete connection on macOS in several files in order to improve tests
Code to scan wifi on linux is not easier to read and also tested. It also introduce a new architecture to more easily manage all functions from all platforms. ## Description Use architecture based on folders and `command` and `parser`. ## Motivation and Context It is easier to unitary tests parser and command generator. ## Usage examples No change of interfaces. ## How Has This Been Tested? Unit tests have been added ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactorization (non-functional change which improve code readibility)
scripts was failing on macOS due to new multiplatform implementation ## How Has This Been Tested? Manual tests: scripts don't have unit tests. ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactorization (non-functional change which improve code readibility)
## Description While scanning for the networks in windows, initially there is a slicing from 5th index which leads to the omitting of first row depicting the ssid of the network. Have changed the slicing from 4th index, so that all the network information be preserved and assigned correctly. ## Motivation and Context This change is required as to get the correct information of the first network been captured and utilized. friedrith#137 ## Usage examples ## How Has This Been Tested? After the change, have tried to scan for the networks, and can see all the information for every network is been listed correctly. Also tried to connect and disconnect with the selected network, which works as expected. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactorization (non-functional change which improve code readibility) Co-authored-by: Geetansh Jain <geetansh.jain@siemens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix failure to connect when the wifi has special characters like
&.Motivation and Context
My wifi has an SSID with special characters so when I try to connect I get an error.
Investigating more about the problem and trying to run
netsh wlan add profile .\nodeWifiConnect.xmlto add the profile generated bynode-wifiI get:Reading the file and comparing it with the profile generated by Windows 10, I found the difference and applied the fix encoding the special characters on SSID.
Types of changes