Split PR #522 [4/9]: Admin scripts package

[seanspeaks]

Summary

• New admin-scripts package extracted from feat(integration-router-v2): Management UI enhancements and CLI improvements #522
• 43 files, ~8,640 lines added
• Depends on core (repository factories, queues, commands, middleware)

Stack

This is PR 4 of 9 splitting #522 into reviewable chunks:

1. Docs → claude/split-522-01-docs
2. Schemas → claude/split-522-02-schemas
3. Core → claude/split-522-03-core
4. Admin Scripts ← you are here
5. AI Agents → claude/split-522-05-ai-agents
6. UI Library → claude/split-522-06-ui-lib
7. CLI → claude/split-522-07-cli
8. Management UI → claude/split-522-08-management-ui
9. E2E & Lockfile → claude/split-522-09-e2e-and-lockfile

Test plan

• Run admin-scripts tests
• Verify imports from @friggframework/core resolve

https://claude.ai/code/session_01D3qzNKrmQXgSJoV6BJkcbQ

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

[d-klotz]

We should probably try/catch that.

[d-klotz]

That's not a good use case name, a use case is usually an intention.

[d-klotz]

what is this.context?

[d-klotz]

Code review

Found 2 issues (both runtime crashes):

1. commands.findRecentExecutions() does not exist -- runtime TypeError on GET /scripts/:scriptName/executions. The router calls commands.findRecentExecutions({...}) but the actual method in @friggframework/core admin-script-commands (from PR Split PR #522 [3/9]: Core framework (DDD refactor) #559) is findRecentAdminProcesses() (or findAdminProcessesByName() for script-specific filtering). The test mocks findRecentExecutions on the mock object, masking the mismatch. This is the same category of bug found in PR Split PR #522 [3/9]: Core framework (DDD refactor) #559 (wrong method names passing through because tests mock the nonexistent method).

frigg/packages/admin-scripts/src/infrastructure/admin-script-router.js

Lines 229 to 234 in a3764cb

	const executions = await commands.findRecentExecutions({
	scriptName,
	status,
	limit: Number.parseInt(limit, 10),
	});

2. integrationRepository.findIntegrations({}) does not exist on the repository interface -- both builtin scripts crash. Both IntegrationHealthCheckScript and OAuthTokenRefreshScript call this.context.integrationRepository.findIntegrations({}) in their getAllIntegrations() helper, but IntegrationRepositoryInterface has no findIntegrations() method. Available methods are: findIntegrationsByUserId, findIntegrationByName, findIntegrationById, findIntegrationByUserId. This will throw TypeError: ...findIntegrations is not a function whenever these scripts run without explicit integrationIds.

frigg/packages/admin-scripts/src/builtins/integration-health-check.js

Lines 145 to 147 in a3764cb

	async getAllIntegrations() {
	return this.context.integrationRepository.findIntegrations({});
	}

frigg/packages/admin-scripts/src/builtins/oauth-token-refresh.js

Lines 133 to 135 in a3764cb

	// In production, would need pagination for large datasets
	return this.context.integrationRepository.findIntegrations({});
	}

---

Additional notes (scored just below the reporting threshold but worth flagging given this is part of the same #522 split that had extensive issues in PR #559):

• schedule-management-use-case.js (~230 lines) is dead code -- never imported by any file. The router uses the 3 split use cases instead. Should be deleted.
• The router's POST /scripts/:scriptName async execution path calls commands.createAdminProcess() and QueuerUtil.send() directly, bypassing use cases -- same "handlers call repositories directly" pattern flagged in PR Split PR #522 [3/9]: Core framework (DDD refactor) #559 (CLAUDE.md Golden Rule).
• oauth-token-refresh.js checks integration.config?.credentials?.access_token but OAuth tokens in Frigg live on separate Credential documents, not Integration.config -- the refresh script will be a no-op in practice.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}