feat: Add Relay-compatible GraphQL endpoint#927
Draft
google-labs-jules[bot] wants to merge 10 commits intomasterfrom
Draft
feat: Add Relay-compatible GraphQL endpoint#927google-labs-jules[bot] wants to merge 10 commits intomasterfrom
google-labs-jules[bot] wants to merge 10 commits intomasterfrom
Conversation
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query. This query follows Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query. This query follows Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type.
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query. This query follows Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type.
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query. This query follows Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type.
Member
|
Didn't realize that would automatically request a review from all three of us, sorry! I've been playing with https://relay.dev at work, and I'm really appreciating the "declarative data fetching" nature of relay. I'd like to try adding a graphql endpoint to CCC, even if we never use it in the app. This PR just adds an endpoint for contacts, but it's a start! |
hawkrives
previously approved these changes
Oct 6, 2025
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query. This query follows Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type. - Use of Zod for type-safe resolution in the `nodeDefinitions`.
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query and a `dictionary` query. These queries follow Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type. - Use of Zod for type-safe resolution in the `nodeDefinitions`. - A refactored and scalable type resolution system for the `node` interface.
hawkrives
previously approved these changes
Oct 6, 2025
hawkrives
previously approved these changes
Oct 6, 2025
drewvolz
previously approved these changes
Oct 6, 2025
|
|
||
| type KnownGraphQLTypeNames = 'Contact' | 'DictionaryDefinition' | ||
|
|
||
| const ContactSchema = z.object({ |
Member
There was a problem hiding this comment.
Think we extracted other schemas to their own files but should be okay
Member
There was a problem hiding this comment.
I figure we can figure out the desired file structure for these later, but … eh, lemme split them out now.
Member
There was a problem hiding this comment.
It's fine, we're making gradual changes and can polish later
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query and a `dictionary` query. These queries follow Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - A modular and scalable architecture with GraphQL types, utilities, and schema assembly separated into their own files. - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type. - Use of Zod for type-safe resolution in the `nodeDefinitions`.
This commit introduces a new Relay-compatible GraphQL endpoint to the server. The new endpoint is available at `/graphql` and currently exposes a `contacts` query and a `dictionary` query. These queries follow Relay conventions, providing a `node` interface for global object identification and a connection-based model for lists. Key features of this implementation include: - A modular and scalable architecture with GraphQL types, utilities, and schema assembly separated into their own files. - Use of `graphql-relay` to ensure compliance with Relay specifications. - Integration of `dataloader` to prevent the N+1 problem by batching and caching data requests. - A Test-Driven Development (TDD) approach, with integration tests that verify the endpoint's functionality, including fetching lists and single nodes. - A custom `URL` scalar type for the `image` field in the `Contact` type. - Use of Zod for type-safe resolution in the `nodeDefinitions`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new Relay-compatible GraphQL endpoint to the server.
The new endpoint is available at
/graphqland currently exposes acontactsquery. This query follows Relay conventions, providing anodeinterface for global object identification and a connection-based model for lists.Key features of this implementation include:
graphql-relayto ensure compliance with Relay specifications.dataloaderto prevent the N+1 problem by batching and caching data requests.PR created automatically by Jules for task 14209361552567519475