Dash mainnet readiness: embedded GBT + Phase C complete + interop fixes

.github/workflows/build.yml

@@ -50,23 +50,31 @@ jobs:
         run: cmake --build build_ci --target c2pool -j$(nproc)
 
       - name: Build tests
+        # All tests now build. The previously-disabled link-cycle group
+        # (test_coin_broadcaster, test_multiaddress_pplns, test_pplns_stress)
+        # is unblocked: test_coin_broadcaster via --start-group/--end-group,
+        # the other two via --whole-archive on libltc_coin.a (forces rpc.cpp.o
+        # in regardless of ld's archive-scan logic, which evidently doesn't
+        # multi-pass extract those refs even inside --start-group).
         run: |
           cmake --build build_ci \
-            --target test_hardening test_share_messages test_coin_broadcaster \
+            --target test_hardening test_share_messages \
                     test_redistribute_address test_redistribute test_auto_ratchet \
                     test_stratum_extensions \
                     core_test sharechain_test share_test \
                     test_threading test_weights \
                     test_header_chain test_mempool test_template_builder \
                     test_doge_chain test_compact_blocks \
-                    test_multiaddress_pplns test_pplns_stress \
                     test_hash_link test_decay_pplns \
                     test_pplns_consensus \
                     test_v36_script_sorting test_v36_cross_impl_refhash \
                     test_phase4_embedded \
                     test_mweb_builder \
                     test_address_resolution test_compute_share_target \
                     test_utxo \
+                    test_dash_credit_pool test_dash_subsidy test_dash_battletest_regressions \
+                    test_dash_pay_attribution \
+                    test_coin_broadcaster test_multiaddress_pplns test_pplns_stress \
             -j$(nproc)
 
       - name: Run tests
@@ -105,6 +113,109 @@ jobs:
         uses: actions/upload-artifact@v7
         with: { name: test-results-linux, path: build_ci/Testing/, retention-days: 7 }
 
+  # ════════════════════════════════════════════════════════════════════════════
+  # Linux AddressSanitizer + UBSan (informational, not gating yet)
+  #
+  # Builds c2pool + the full test suite with -fsanitize=address,undefined and
+  # runs ctest under ASAN/UBSAN_OPTIONS. Catches use-after-free, heap overflow,
+  # uninitialized read, integer overflow, etc. at PR time instead of via 12-h
+  # soaks. Conan deps stay un-sanitized (static libs); libasan still intercepts
+  # all allocations including those from deps, so UAFs that touch our code are
+  # caught.
+  #
+  # Currently `continue-on-error: true` so reports are visible without blocking
+  # merges while we work through the audit (Phase 1 of the socket-lifecycle
+  # fundamental fix; see frstrtr/the/docs/c2pool-socket-lifecycle-fundamental-fix.md).
+  # Will flip to required once known UAFs are fixed (Phase 7).
+  # ════════════════════════════════════════════════════════════════════════════
+  linux-asan:
+    name: Linux x86_64 (AsAN+UBSan)
+    runs-on: ubuntu-24.04
+    continue-on-error: true
+    steps:
+      - uses: actions/checkout@v6
+
+      - name: Install system dependencies
+        run: |
+          sudo apt-get update -qq
+          sudo apt-get install -y --no-install-recommends \
+            g++ cmake make libleveldb-dev libsecp256k1-dev
+
+      - uses: actions/setup-python@v6
+        with: { python-version: '3.12' }
+
+      - name: Install Conan 2
+        run: pip install "conan>=2.0,<3.0"
+
+      - name: Detect Conan profile
+        run: |
+          conan profile detect --force
+          sed -i 's/compiler.cppstd=.*/compiler.cppstd=20/' "$(conan profile path default)"
+
+      - name: Restore Conan cache
+        uses: actions/cache@v5
+        with:
+          path: ~/.conan2
+          key: conan2-ubuntu24-gcc13-${{ hashFiles('conanfile.txt') }}
+
+      - name: Conan install
+        run: conan install . --build=missing --output-folder=build_asan --settings=build_type=Release
+
+      - name: Configure (Release + AsAN + UBSan)
+        # NOTE 1: must match the build_type passed to `conan install` (Release).
+        # Conan generates `*-Target-release.cmake` with INTERFACE_INCLUDE_DIRECTORIES
+        # wrapped in $<$<CONFIG:Release>:...>, so a mismatched cmake build type
+        # (e.g. RelWithDebInfo) silently drops every conan dep's include path.
+        # We get full optimization + debug symbols via -g in CXX_FLAGS.
+        #
+        # NOTE 2: -fno-sanitize=vptr disables the UBSan vptr check, which would
+        # require leveldb (and other foreign polymorphic types) to expose their
+        # typeinfo. leveldb is built without that, causing "undefined reference
+        # to typeinfo for leveldb::DB" link errors. All other UBSan checks
+        # remain on.
+        run: |
+          cmake -S . -B build_asan \
+            -DCMAKE_TOOLCHAIN_FILE=build_asan/conan_toolchain.cmake \
+            -DCMAKE_BUILD_TYPE=Release \
+            -DCMAKE_CXX_FLAGS="-fsanitize=address,undefined -fno-sanitize=vptr -fno-omit-frame-pointer -fno-sanitize-recover=undefined -g" \
+            -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address,undefined -fno-sanitize=vptr" \
+            -DCMAKE_SHARED_LINKER_FLAGS="-fsanitize=address,undefined -fno-sanitize=vptr"
+
+      - name: Build c2pool + tests
+        run: |
+          cmake --build build_asan \
+            --target c2pool \
+                    test_hardening test_share_messages \
+                    test_redistribute_address test_redistribute test_auto_ratchet \
+                    test_stratum_extensions \
+                    core_test sharechain_test share_test \
+                    test_threading test_weights \
+                    test_header_chain test_mempool test_template_builder \
+                    test_doge_chain test_compact_blocks \
+                    test_hash_link test_decay_pplns \
+                    test_pplns_consensus \
+                    test_v36_script_sorting test_v36_cross_impl_refhash \
+                    test_phase4_embedded \
+                    test_mweb_builder \
+                    test_address_resolution test_compute_share_target \
+                    test_utxo \
+                    test_dash_credit_pool test_dash_subsidy test_dash_battletest_regressions \
+                    test_dash_pay_attribution \
+                    test_coin_broadcaster test_multiaddress_pplns test_pplns_stress \
+            -j$(nproc)
+
+      - name: Run tests under sanitizers
+        working-directory: build_asan
+        env:
+          ASAN_OPTIONS: detect_leaks=0:check_initialization_order=1:strict_string_checks=1:abort_on_error=0
+          UBSAN_OPTIONS: print_stacktrace=1:halt_on_error=0
+        run: ctest --output-on-failure -j$(nproc) --exclude-regex "LiveTest\."
+
+      - name: Upload sanitizer test results on failure
+        if: failure()
+        uses: actions/upload-artifact@v7
+        with: { name: test-results-linux-asan, path: build_asan/Testing/, retention-days: 7 }
+
   # ════════════════════════════════════════════════════════════════════════════
   # Web-static JS verify (typecheck + build + tests + bundle-size gate)
   # Covers web-static/sharechain-explorer/: the Explorer + PPLNS View

.gitignore

@@ -88,7 +88,15 @@ doc/EMBEDDED_COIN_NODE_DESIGN.md
 
 #c2pool
 /logs
+ # /data is ignored except for the in-tree DMN snapshots (Phase C-PAY
+# step 3c). Force-add new snapshot files with `git add -f` when
+# refreshing via --dump-mn-snapshot.
 /data
+!/data/
+/data/*
+!/data/dash/
+/data/dash/*
+!/data/dash/dmn_snapshot_*.dat
 /legacy
 /ltc_testnet/
 /ltc/
@@ -158,6 +166,11 @@ test/test_*_include.cmake
 SHA256SUMS
 
 CLAUDE.md
-
+# CMake build dirs (any name with a `build` prefix or `build` exact match)
+build/
+build-*/
+# Autoconf/autoreconf backup files (e.g. external/dashbls/configure~)
+*~
+ref/
 external-logs/
 tools/

CMakeLists.txt

@@ -85,6 +85,75 @@ if(SECP256K1_INCLUDE_DIRS)
     include_directories(${SECP256K1_INCLUDE_DIRS})
 endif()
 
+# ── Phase L step 0: dashbls (Apache 2.0, dashpay/bls-signatures) ──────────
+#
+# Dashbls is the Chia BLS fork dashcore links against. We vendor a pruned
+# copy under external/dashbls/ and build via dashbls's own autotools
+# (autoreconf + configure + make), matching dashcore's exact build path.
+#
+# Why autotools and not dashbls's CMakeLists: dashbls's CMake build is
+# upstream-broken for general use (its relic_conf.h.in template is
+# .gitignored, gets regenerated by autoreconf using autoconf #undef
+# syntax that CMake's configure_file doesn't substitute, leaving every
+# arch-define as #undef → relic_arch.h falls through to the AVR
+# microcontroller branch and tries to #include <avr/pgmspace.h>).
+# Autotools is dashbls's primary supported build path (proven by
+# dashcore using it on Linux/macOS daily).
+#
+# Build host requirements: autoconf, automake, libtool, pthread.
+# - Linux: apt install autoconf automake libtool (typically already there)
+# - macOS: brew install autoconf automake libtool  (uses glibtoolize,
+#   handled by dashbls's autogen.sh)
+# - Windows native: MSYS2 or WSL2 — autotools doesn't work in MSVC
+#   natively. Cross-compile from Linux is the documented escape hatch.
+#
+# Build artifact: ${DASHBLS_INSTALL}/lib/libdashbls.a — a self-contained
+# static archive bundling relic + mimalloc + the BLS C++ wrapper. Headers
+# go to ${DASHBLS_INSTALL}/include/dashbls/.
+
+include(ExternalProject)
+
+set(DASHBLS_PREFIX  ${CMAKE_BINARY_DIR}/external/dashbls)
+set(DASHBLS_INSTALL ${DASHBLS_PREFIX}/install)
+set(DASHBLS_LIB     ${DASHBLS_INSTALL}/lib/libdashbls.a)
+set(DASHBLS_INCLUDE ${DASHBLS_INSTALL}/include/dashbls)
+
+ExternalProject_Add(dashbls_external
+    SOURCE_DIR        ${CMAKE_SOURCE_DIR}/external/dashbls
+    PREFIX            ${DASHBLS_PREFIX}
+    INSTALL_DIR       ${DASHBLS_INSTALL}
+    BUILD_IN_SOURCE   1
+    CONFIGURE_COMMAND
+        bash -c "cd <SOURCE_DIR> && (test -f configure || ./autogen.sh) && ./configure --prefix=<INSTALL_DIR> --enable-shared=no --enable-static=yes --disable-tests --disable-bench"
+    BUILD_COMMAND     bash -c "cd <SOURCE_DIR> && make -j"
+    INSTALL_COMMAND   bash -c "cd <SOURCE_DIR> && make install"
+    BUILD_BYPRODUCTS  ${DASHBLS_LIB}
+    LOG_DOWNLOAD      0
+    LOG_CONFIGURE     1
+    LOG_BUILD         1
+    LOG_INSTALL       1
+)
+
+# Imported target that wraps the autotools-built static library so
+# downstream targets just `target_link_libraries(... dashbls)`. The
+# include directory is ${DASHBLS_INSTALL}/include so consumers
+# `#include <dashbls/bls.hpp>`.
+add_library(dashbls STATIC IMPORTED GLOBAL)
+add_dependencies(dashbls dashbls_external)
+# dashbls's Makefile.am doesn't install headers — point at the source
+# tree's include/ instead. Public C++ surface is `<dashbls/bls.hpp>` etc.
+# dashbls's headers transitively #include <relic_conf.h> (autotools-
+# generated by the autoreconf+configure step we triggered above), so
+# expose relic's include dir too. INTERFACE_INCLUDE_DIRECTORIES on
+# IMPORTED targets requires existing dirs at configure time — we
+# pre-create both via file(MAKE_DIRECTORY) so a fresh checkout
+# configures cleanly even before the dashbls_external build has run.
+file(MAKE_DIRECTORY ${CMAKE_SOURCE_DIR}/external/dashbls/depends/relic/include)
+set_target_properties(dashbls PROPERTIES
+    IMPORTED_LOCATION             ${DASHBLS_LIB}
+    INTERFACE_INCLUDE_DIRECTORIES "${CMAKE_SOURCE_DIR}/external/dashbls/include;${CMAKE_SOURCE_DIR}/external/dashbls/depends/relic/include"
+)
+
 add_subdirectory(src)
 add_subdirectory(test)
 # add_subdirectory(benchmark)

external/dashbls/.clang-format

@@ -0,0 +1,17 @@
+BasedOnStyle: Google
+UseTab: Never
+ColumnLimit: 80
+IndentWidth: 4
+TabWidth: 4
+AllowShortIfStatementsOnASingleLine: false
+IndentCaseLabels: false
+AccessModifierOffset: -4
+BinPackArguments: false
+BinPackParameters: false
+AlignAfterOpenBracket: AlwaysBreak
+IndentCaseLabels: true
+AllowAllParametersOfDeclarationOnNextLine: false
+BreakBeforeBraces: Custom
+BraceWrapping:
+    AfterFunction: true
+PenaltyReturnTypeOnItsOwnLine: 1000

external/dashbls/.flake8

@@ -0,0 +1,4 @@
+[flake8]
+max-line-length = 120
+exclude = ./typings/**/* python-impl/fields.py
+ignore = E203,W503,E501

external/dashbls/.github/workflows/build-binds.yml

@@ -0,0 +1,96 @@
+name: Build and test binds
+
+on:
+  push:
+    branches:
+      - main
+    tags:
+      - '**'
+  pull_request:
+    branches:
+      - '**'
+
+concurrency:
+  # SHA is added to the end if on `main` to let all main workflows run
+  group: ${{ github.ref }}-${{ github.workflow }}-${{ github.event_name }}-${{ (github.ref == 'refs/heads/main') && github.sha || '' }}
+  cancel-in-progress: true
+
+jobs:
+  build:
+    name: ${{ matrix.os }}, Python ${{ matrix.python }}, Go ${{ matrix.golang }}, Rust ${{ matrix.rust }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macos-latest, ubuntu-latest]
+        golang: [ '1.24' ]
+        python: ['3.10', '3.11', '3.12', '3.13']
+        rust: [ '1.91.0' ]
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v3
+
+    - uses: chia-network/actions/setup-python@main
+      with:
+        python-version: ${{ matrix.python }}
+
+    - name: Test Python implementation
+      run: |
+        python python-impl/impl-test.py
+
+    - name: Install Emscripten SDK
+      uses: mymindstorm/setup-emsdk@v11
+
+    - name: Build JavaScript bindings
+      run: |
+        emcc -v
+        sh emsdk_build.sh
+
+    - name: Test JavaScript bindings
+      run: |
+        sh js_test.sh
+
+    - name: Install Go
+      uses: actions/setup-go@v2
+      with:
+        go-version: ^${{ matrix.golang }}
+
+    - name: Prepare build system for Ubuntu
+      if: startsWith(matrix.os, 'ubuntu')
+      run: |
+        sudo apt-get update
+        sudo apt-get install -qq --yes valgrind libgmp-dev cmake
+        hash -r
+        cmake --version
+
+    - name: Prepare build system for macOS
+      if: startsWith(matrix.os, 'macos')
+      run: |
+        ls -l
+        export MACOSX_DEPLOYMENT_TARGET=10.14
+        brew install gmp
+
+    - name: Build library using CMake
+      run: |
+        mkdir -p build && cd build
+        cmake .. -DCMAKE_BUILD_TYPE=Debug
+        cmake --build . -- -j 6
+
+    - name: Build Go bindings
+      run: |
+        cd go-bindings
+        make config
+        make
+
+    - name: Install Rust
+      run: |
+        rustup toolchain install ${{ matrix.rust }}
+        rustup default ${{ matrix.rust }}
+        rustc --version
+        cargo --version
+
+    - name: Build and test Rust bindings
+      run: |
+        cd rust-bindings/bls-dash-sys
+        cargo test