Fix infinite recursion in project discovery on symlink cycles - #4421
Open
michaelglass wants to merge 1 commit into
Open
Fix infinite recursion in project discovery on symlink cycles#4421michaelglass wants to merge 1 commit into
michaelglass wants to merge 1 commit into
Conversation
ProjectFile.SearchAllProjectRelatedFiles walks the directory tree to find *proj* files, following directory symlinks with no cycle detection. A self-referential or cyclic directory symlink — e.g. the macOS SDK ncurses symlink loops inside a Nix `.devenv` profile — drives the walk into unbounded recursion, so `paket restore` hangs (surfacing downstream as "project.assets.json stale ... 'dotnet restore' timed out after 300s"). Resolve each directory to its canonical, symlink-followed path and skip ones already visited. Symlinks are still followed (legitimately symlinked project directories are still discovered) — only repeats are pruned, so cycles terminate and each physical project is reported once. Canonicalization uses libc `realpath` on Unix (Paket.Core targets net461/netstandard2.0, which lack DirectoryInfo.ResolveLinkTarget) with a lexical Path.GetFullPath fallback on Windows and on any failure. Adds a regression test: red without the fix (the project is found 32x before the path outgrows PATH_MAX), green with it (found exactly once). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
PROPERTYZ: command not found)No integration failure touched the symlink-discovery path.