Skip to content

Parse fallback attribute during parseManifest #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nielslanting wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Parse fallback attribute during parseManifest #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
525d38e
Parse fallback attribute during parseManifest
nielslanting Jul 28, 2022
0379975
Added fallback to PackagingManifestItem type
nielslanting Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/packaging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,15 @@ class Packaging {
type = item.getAttribute("media-type") || "",
overlay = item.getAttribute("media-overlay") || "",
properties = item.getAttribute("properties") || "";
fallback = item.getAttribute("fallback") || "";

manifest[id] = {
"href" : href,
// "url" : href,
"type" : type,
"overlay" : overlay,
"properties" : properties.length ? properties.split(" ") : []
"properties" : properties.length ? properties.split(" ") : [],
"fallback" : fallback,
};

});
Expand Down
3 changes: 2 additions & 1 deletion types/packaging.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ export interface PackagingSpineItem {
export interface PackagingManifestItem {
href: string,
type: string,
properties: Array<string>
properties: Array<string>,
fallback: string
}

export interface PackagingManifestObject {
Expand Down