fix(multihop_qa): correct frozen_lake.masking import path#407
Closed
Hecate0821 wants to merge 1 commit into
Closed
fix(multihop_qa): correct frozen_lake.masking import path#407Hecate0821 wants to merge 1 commit into
Hecate0821 wants to merge 1 commit into
Conversation
The masking helpers live under training.examples.rl.frozen_lake, not training.examples.frozen_lake — importing the latter raised ModuleNotFoundError at module load and made train_multihop_qa_igpo.py unrunnable (and broke the smoke-imports test). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
train_multihop_qa_igpo.pyimportedtraining.examples.frozen_lake.masking, but the actual path istraining.examples.rl.frozen_lake.masking— so the example was unimportable onmain(ModuleNotFoundError at line 38) and broketraining/tests/test_smoke_imports.py.rl.segment to the import.Test plan
FIREWORKS_API_KEY=dummy python -c "import training.examples.multihop_qa.train_multihop_qa_igpo"→ OKFIREWORKS_API_KEY=dummy pytest training/tests/test_smoke_imports.py→ 63 passed (was 62 passed + 1 fail before fix)pytest training/tests/unit/ --ignore=training/tests/unit/test_sft_loop.py→ 497 passed, 32 skipped🤖 Generated with Claude Code