Feature/ci

.github/dependabot.yml

@@ -0,0 +1,11 @@
+version: 2
+updates:
+  # Keep GitHub Actions up-to-date
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    groups: #all in one PR
+      github-actions-all:
+        patterns:
+          - "*"

.github/workflows/ci-linux.yml

@@ -5,9 +5,6 @@ on:
     branches:
       - master
       - develop
-      - 'feature/*'
-      - 'hotfix/*'
-      - 'release/*'
     tags:
       - '*'
   pull_request:
@@ -25,7 +22,7 @@ jobs:
 
     strategy:
       matrix:
-        php-versions: [ '8.2', '8.5' ]
+        php-versions: [ '8.3', '8.5' ]
         coverage: [none]
       fail-fast: false
 
@@ -38,15 +35,15 @@ jobs:
           coverage: ${{ matrix.coverage }}
 
       - name: Checkout Galette core
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           repository: galette/galette
           path: galette-core
           fetch-depth: 1
           ref: develop
 
       - name: Checkout plugin
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           path: galette-core/galette/plugins/plugin-paypal
 
@@ -56,7 +53,7 @@ jobs:
           echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
       - name: Cache dependencies
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         with:
           path: ${{ steps.composer-cache.outputs.dir }}
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.json') }}
@@ -73,7 +70,7 @@ jobs:
           ../../vendor/bin/phpcs lib/ ./*.php
 
       - name: CS Fixer
-        if: matrix.php-versions == '8.1'
+        if: matrix.php-versions == '8.3'
         run: |
           cd galette-core/galette/plugins/plugin-paypal
           ../../vendor/bin/php-cs-fixer check --show-progress=dots --verbose --diff
@@ -100,21 +97,23 @@ jobs:
       matrix:
         include:
           #always tests higher stable php version with lower db version
-          #enable coverage on higher stable php version with higher postrgesql version
-          #lower php version
-          - { php-version: "8.2", db-image: "mysql:5.7", coverage: none, always: false }
-          - { php-version: "8.2", db-image: "mysql:8.1", coverage: none, always: false }
-          - { php-version: "8.2", db-image: "mariadb:10.4", coverage: none, always: false }
-          - { php-version: "8.2", db-image: "mariadb:11", coverage: none, always: false }
-          - { php-version: "8.2", db-image: "postgres:11", coverage: none, always: false }
-          - { php-version: "8.2", db-image: "postgres:16", coverage: none, always: false }
+          #enable coverage on higher stable php version with higher PostgreSQL version
+          #cache must be disabled on one always enabled build (not coverage one, this already takes much time than others)
           #higher stable php version
-          - { php-version: "8.5", db-image: "mysql:5.7", coverage: none, always: true }
-          - { php-version: "8.5", db-image: "mysql:8.1", coverage: none, always: false }
-          - { php-version: "8.5", db-image: "mariadb:10.4", coverage: none, always: true }
-          - { php-version: "8.5", db-image: "mariadb:11", coverage: none, always: false }
-          - { php-version: "8.5", db-image: "postgres:11", coverage: none, always: true }
-          - { php-version: "8.5", db-image: "postgres:16", coverage: none, always: true }
+          - { php-version: "8.5", db-image: "postgres:13", coverage: none, cache: true, always: true }
+          - { php-version: "8.5", db-image: "postgres:17", coverage: none, cache: true, always: true }
+          - { php-version: "8.5", db-image: "mysql:8.0", coverage: none, cache: true, always: true }
+          - { php-version: "8.5", db-image: "mysql:9.1", coverage: none, cache: true, always: false }
+          - { php-version: "8.5", db-image: "mariadb:10.5", coverage: none, cache: false, always: true }
+          - { php-version: "8.5", db-image: "mariadb:11.6", coverage: none, cache: true, always: false }
+          #always one test with lower php version
+          #lower php version
+          - { php-version: "8.3", db-image: "postgres:13", coverage: none, cache: true, always: false }
+          - { php-version: "8.3", db-image: "postgres:17", coverage: none, cache: true, always: true }
+          - { php-version: "8.3", db-image: "mysql:8.0", coverage: none, cache: true, always: false }
+          - { php-version: "8.3", db-image: "mysql:9.1", coverage: none, cache: true, always: false }
+          - { php-version: "8.3", db-image: "mariadb:10.5", coverage: none, cache: true, always: false }
+          - { php-version: "8.3", db-image: "mariadb:11.6", coverage: none, cache: true, always: false }
       fail-fast: false
 
     env:
@@ -168,37 +167,17 @@ jobs:
           echo "npm $(npm --version)"
           docker exec ${{ job.services.db.id }} bash -c "if [[ -n \$(command -v psql) ]]; then psql --version; else if [[ -n \$(command -v mysql) ]]; then mysql --version; else mariadb --version; fi fi"
 
-      - name: Checkout Galette core
+      - name: Build Galette
         if: env.skip != 'true'
-        uses: actions/checkout@v4
+        uses: galette/.github/actions/build-galette@main
         with:
-          repository: galette/galette
-          path: galette-core
-          fetch-depth: 1
-          ref: develop
+          php-version: ${{ matrix.php-version }}
 
       - name: Checkout plugin
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           path: galette-core/galette/plugins/plugin-paypal
 
-      - name: "Restore dependencies cache"
-        if: env.skip != 'true'
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.composer/cache/
-            ~/.npm/_cacache/
-          key: "${{ runner.os }}-galette-${{ matrix.php-version }}-${{ hashFiles('galette/composer.lock', 'package-lock.json') }}"
-          restore-keys: |
-            ${{ runner.os }}-galette-${{ matrix.php-version }}-
-
-      - name: Install dependencies
-        if: env.skip != 'true'
-        run: |
-          cd galette-core
-          bin/install_deps
-
       - name: Init for PostgreSQL
         env:
           POSTGRES_HOST: localhost

lib/GalettePaypal/Paypal.php

@@ -36,10 +36,10 @@
  */
 class Paypal
 {
-    public const TABLE = 'preferences';
+    public const string TABLE = 'preferences';
 
-    public const PAYMENT_PENDING = 'Pending';
-    public const PAYMENT_COMPLETE = 'Complete';
+    public const string PAYMENT_PENDING = 'Pending';
+    public const string PAYMENT_COMPLETE = 'Complete';
 
     private Db $zdb;
 

lib/GalettePaypal/PaypalHistory.php

@@ -39,15 +39,15 @@
  */
 class PaypalHistory extends History
 {
-    public const TABLE = 'history';
-    public const PK = 'id_paypal';
-
-    public const STATE_NONE = 0;
-    public const STATE_PROCESSED = 1;
-    public const STATE_DONE = 2;
-    public const STATE_ERROR = 3;
-    public const STATE_INCOMPLETE = 4;
-    public const STATE_ALREADYDONE = 5;
+    public const string TABLE = 'history';
+    public const string PK = 'id_paypal';
+
+    public const int STATE_NONE = 0;
+    public const int STATE_PROCESSED = 1;
+    public const int STATE_DONE = 2;
+    public const int STATE_ERROR = 3;
+    public const int STATE_INCOMPLETE = 4;
+    public const int STATE_ALREADYDONE = 5;
 
     private int $id;
 

lib/GalettePaypal/PluginGalettePaypal.php

@@ -148,15 +148,8 @@ public function getMyDashboards(): array
      */
     public function isInstalled(): bool
     {
-        try {
-            $this->zdb->execute($this->zdb->select(PAYPAL_PREFIX . Paypal::TABLE)->limit(1));
-            $this->zdb->execute($this->zdb->select(PAYPAL_PREFIX . PaypalHistory::TABLE)->limit(1));
-            return true;
-        } catch (\Throwable $e) {
-            if (!$this->zdb->isMissingTableException($e)) {
-                throw $e;
-            }
-        }
-        return false;
+        return
+            $this->zdb->tableExists(PAYPAL_PREFIX . Paypal::TABLE)
+            && $this->zdb->tableExists(PAYPAL_PREFIX . PaypalHistory::TABLE);
     }
 }