Unified SZ implementation that can handle both websky and Agora#188
Unified SZ implementation that can handle both websky and Agora#188zonca wants to merge 35 commits intogalsci:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Pull request overview
This pull request refactors the SZ (Sunyaev-Zeldovich) model implementation to create a unified approach that can handle both WebSky and Agora simulation templates. The WebSkySZ class is renamed to SimpleSZ and generalized to accept arbitrary template files rather than hardcoding WebSky-specific paths.
Changes:
- Renamed
WebSkySZtoSimpleSZwith a more flexible API accepting template filenames - Updated preset configurations to use the new
SimpleSZclass for both existing WebSky models (ksz1, tsz1) and new Agora models (ksz2, tsz2, ksz3, tsz3) - Added a verification notebook to compare WebSky and Agora SZ templates
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pysm3/models/websky.py | Refactored WebSkySZ to SimpleSZ, removing hardcoded filename logic and accepting template_name parameter |
| src/pysm3/models/init.py | Updated exports to replace WebSkySZ with SimpleSZ |
| tests/test_websky.py | Updated test to use new SimpleSZ API with explicit template_name parameter |
| src/pysm3/data/presets.cfg | Updated existing presets (ksz1, tsz1) and added new Agora presets (ksz2, ksz3, tsz2, tsz3) |
| docs/preprocess-templates/verify_templates/compare_websky_agora_sz.ipynb | New notebook for comparing WebSky and Agora SZ templates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
setup, add joint_limits and remove_monopole functions, and enhance thermal and kinematic SZ comparisons
|
@giuspugl @1cosmologist @seclark @brandonshensley I have implemented Agora SZ components and compared with websky, https://gist.github.com/zonca/36576153be6b2ef706b61da4d6a90c33 |
zonca
force-pushed
the
agora_sz
branch
2 times, most recently
from
24ca15e to
b6a672a
Compare
|
I had a look at the notebook and I think it looks fine. One comment I have for the tSZ validation is that Agora tSZ minus WebSky tSZ is not a good check as these are different realizations and should not be similar (and we see that). No idea what to make of the monopole. |
|
@1cosmologist thanks for the feedback, would you be able to do a pull request against this pull request to improve the docs? If we need more space we can create a agora.rst file all dedicated to the Agora-based models. |
Prevent duplicate log messages by clearing existing handlers and disabling propagation to the root logger.
- Clears existing handlers in set_verbosity to prevent accumulation - Disables propagation to root logger to avoid double logging in environments like Jupyter - Updates compare_websky_agora_sz.ipynb to use pysm3.set_verbosity
…omposite plot generation
|
Adding composite images for kSZ and tSZ template verification. tSZ
kSZ
|
|
needed to rebase everything and enable git lfs, moved to #244 |
No description provided.