docs: update rake task hook names#8
Conversation
pboling
left a comment
pboling
left a comment
There was a problem hiding this comment.
I was avoiding this type of change because I was trying to maintain maximum drop-in replacement vibes... but perhaps that is better accomplished via an optionally generated task, based on an ENV variable... In any case, I think I'm fine with a clean break here.
NOTE: that this project may still merge back into turbo_tests - I'm discussing with @ilyazub.
|
The CI failures are due to an issue in the latest test harness I released. A fix for that is incoming as well. |
|
@pboling oh I hadn't realized that you hadn't changed those names - in that case I think that's fine, and so I'd just revert this I had duplicated that block in my local assuming they had been changed, which is why I wouldn't have gotten an error 😅 |
|
also glad to hear you've in active discussions with @ilyazub - fwiw even if you don't merge back in, it'd be great if we could get the original turbo_tests some love which I'd be happy to help with. From my POV the main thing missing from the original is serpapi/turbo_tests#82, otherwise its working a treat 🤷 (not that your work isn't appreciated, I'm just not sure how wide the gap is between the original and here, beyond my rake stuff 😅 ) |
|
The gap keeps getting larger! I have implemented quite a bit in this one. @ilyazub is just very busy, and they don't use it anymore at SerpAPI, so it is low priority. |
|
I went with the alias route, so now both work. |
2 participants
No description provided.