fix: re-fetch OIDC token on 401 to handle token expiry during retries - #1682
Merged
Merged
Conversation
gardener-prow
Bot
added
do-not-merge/needs-kind
Michael5601
force-pushed
the
refetch-token-on-401-to-avoid-oidc-token-ttl
branch
from
July 28, 2026 13:52
23dcfdf to
a06bd74
Compare
Member
|
check/fix linter-error |
ccwienk
requested changes
Jul 29, 2026
Michael5601
force-pushed
the
refetch-token-on-401-to-avoid-oidc-token-ttl
branch
from
July 29, 2026 11:52
a06bd74 to
74b9413
Compare
ccwienk
reviewed
Jul 30, 2026
Michael5601
force-pushed
the
refetch-token-on-401-to-avoid-oidc-token-ttl
branch
from
July 30, 2026 08:19
74b9413 to
fd1b841
Compare
Member
|
/kind bug |
ccwienk
approved these changes
Jul 31, 2026
ccwienk
left a comment
ccwienk
left a comment
Member
There was a problem hiding this comment.
All comments addressed, looks good.
Member
|
/lgtm |
gardener-prow
Bot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccwienk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 123e1ba965f0f3699c26d36a705ec8ebbb7faa5b |
gardener-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github-auth action fetched the OIDC token once upfront before the token exchange retry loop. With high retry counts and long backoff, the loop can run longer than the 5-minute OIDC token TTL, causing the exchange to fail with a 401 even though the infrastructure issue has self-healed.
The fix fetches the OIDC token once upfront and only re-fetches it when the token exchange returns a 401, keeping the number of OIDC token requests minimal. All other 4xx errors fail immediately since retrying the same request won't help. Transient errors (5xx, timeouts, 408, 429) continue to retry with the same token.
As part of this change, sys.exit(1) calls inside the HTTP layer were replaced with typed HttpError and TransientError exceptions, allowing exchange_token to distinguish between error types and react accordingly.
Release note: