Skip to content

feat(ocm): Add support for non-tar json component descriptor blobs - #1683

Merged
ccwienk merged 4 commits into
gardener:masterfrom
8R0WNI3:master
Aug 4, 2026
Merged

feat(ocm): Add support for non-tar json component descriptor blobs#1683
ccwienk merged 4 commits into
gardener:masterfrom
8R0WNI3:master

Conversation

@8R0WNI3

@8R0WNI3 8R0WNI3 commented Jul 30, 2026

Copy link
Copy Markdown
Member

Fixes open-component-model/open-delivery-gear#204

Release note:

The Python OCM lib now features component descriptor blobs of non-tar type as well as json type too

@8R0WNI3 8R0WNI3 added the kind/task General task label Jul 30, 2026
@8R0WNI3
8R0WNI3 requested a review from ccwienk as a code owner July 30, 2026 08:50
@8R0WNI3 8R0WNI3 added the area/delivery Delivery related label Jul 30, 2026
@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 30, 2026

@ccwienk ccwienk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall — clean refactor, and the layers_count walrus bug fix is a nice bonus.

Two small notes:

  • component_descriptor_from_tarfileobj (and the async raw_component_descriptor_from_oci) were public — did you check for external consumers? Happy to approve either way, just want to make sure it's on your radar.

  • Minor readability nit in normalize_nulls:

    k: normalize_nulls(v) if v is not None else ([] if k in null_allowed_for else v)

    The else v arm silently keeps None for non-listed keys, which is correct but not immediately obvious. A short comment there would help a future reader.

8R0WNI3 added 4 commits August 4, 2026 10:46
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
@8R0WNI3

8R0WNI3 commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

component_descriptor_from_tarfileobj (and the async raw_component_descriptor_from_oci) were public — did you check for external consumers?

I did check but I could not find any external consumers.

The else v arm silently keeps None for non-listed keys, which is correct but not immediately obvious. A short comment there would help a future reader.

I have added a short comment on this :-)

@8R0WNI3
8R0WNI3 requested a review from ccwienk August 4, 2026 08:48
@gardener-prow gardener-prow Bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Aug 4, 2026
@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2026
@gardener-prow

gardener-prow Bot commented Aug 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccwienk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow

gardener-prow Bot commented Aug 4, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: ce80f2d9c769fe532ff2ee82a1a1f9d9985e12ea

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2026
@ccwienk
ccwienk merged commit d671e74 into gardener:master Aug 4, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/task General task lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic support for OCM v2

2 participants