feat(ocm): Add support for non-tar json component descriptor blobs - #1683
Conversation
ccwienk
left a comment
There was a problem hiding this comment.
LGTM overall — clean refactor, and the layers_count walrus bug fix is a nice bonus.
Two small notes:
-
component_descriptor_from_tarfileobj(and the asyncraw_component_descriptor_from_oci) were public — did you check for external consumers? Happy to approve either way, just want to make sure it's on your radar. -
Minor readability nit in
normalize_nulls:k: normalize_nulls(v) if v is not None else ([] if k in null_allowed_for else v)
The
else varm silently keepsNonefor non-listed keys, which is correct but not immediately obvious. A short comment there would help a future reader.
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
I did check but I could not find any external consumers.
I have added a short comment on this :-) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccwienk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: ce80f2d9c769fe532ff2ee82a1a1f9d9985e12ea |
Fixes open-component-model/open-delivery-gear#204
Release note: