Track preserved failed machines in MCS and MCD status#1092
Track preserved failed machines in MCS and MCD status#1092thiyyakat wants to merge 12 commits intogardener:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| return totalAvailableReplicas | ||
| } | ||
|
|
||
| // GetPreservedFailedReplicaCountForMachineSets returns the number of available machines corresponding to the given machine sets. |
There was a problem hiding this comment.
Docstring needs to be corrected
cf58e73 to
3ef4b96
Compare
3ef4b96 to
a47f9a5
Compare
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: b6085293a87bf4863ad9b9ac74d7330449a41f91 |
|
New changes are detected. LGTM label has been removed. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR introduces 2 changes:
preservedFailedReplicasadded to the MCS and MCD Status.failedMachinein the MCS and MCD Status. This will also prevent shoot reconciliation from getting stuck.Additionally, the PR modifies the sorting logic for
ActiveMachines-- if two machines are preserved, one auto-preserved and one explicitly preserved through annotation by user/operator, the sorting logic de-prioritizes explicitly preserved machines for deletion.The usage doc for preservation has been updated with a warning regarding the behaviour of DWD when number of preserved failed machines exceeds the threshold set for DWD.
Which issue(s) this PR fixes:
Extends #1008
Special notes for your reviewer:
MCM unit and integration tests passed with changes.
The changes were manually tested out using virtual provider. Below log shows MCD status when it has 1 preserved failed replica.
Release note: