Skip to content

Code cleanup#1095

Open
r4mek wants to merge 11 commits intogardener:masterfrom
r4mek:TODOs
Open

Code cleanup#1095
r4mek wants to merge 11 commits intogardener:masterfrom
r4mek:TODOs

Conversation

@r4mek
Copy link
Copy Markdown
Contributor

@r4mek r4mek commented Apr 8, 2026 •
edited
Loading

What this PR does / why we need it:
Cleaning up code

Which issue(s) this PR fixes:
Extends #1087

Special notes for your reviewer:

Release note:

@r4mek r4mek requested a review from a team as a code owner April 8, 2026 08:57
@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 8, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign r4mek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2026
@r4mek
Copy link
Copy Markdown
Contributor Author

r4mek commented Apr 8, 2026

/kind enhancement

@gardener-prow gardener-prow Bot added kind/enhancement Enhancement, improvement, extension and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 8, 2026
@aaronfern aaronfern mentioned this pull request Apr 10, 2026
Open
takoverflow
takoverflow reviewed Apr 16, 2026
View reviewed changes
Comment thread pkg/controller/controller_utils.go Outdated
Comment thread pkg/controller/deployment_sync.go Outdated
Comment thread pkg/controller/controller_utils.go Outdated
@gardener-prow gardener-prow Bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Apr 16, 2026
@takoverflow
Copy link
Copy Markdown
Member

takoverflow commented Apr 22, 2026

/lgtm

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 22, 2026

LGTM label has been added.

DetailsGit tree hash: 9182638326b3c09c3f0f095f4d63e9ac2a375844

@gagan16k
Copy link
Copy Markdown
Member

gagan16k commented Apr 22, 2026

/lgtm

1 similar comment
@thiyyakat
Copy link
Copy Markdown
Member

thiyyakat commented Apr 22, 2026

/lgtm

@r4mek
Copy link
Copy Markdown
Contributor Author

r4mek commented Apr 22, 2026

After discussion with @gagan16k , changed the code to avoid printing Warning message when machine.sapcloud.io/last-deployment-replica-change-by-scaler-time is not set.

@gardener-prow gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2026
@gagan16k
Copy link
Copy Markdown
Member

gagan16k commented Apr 22, 2026

/lgtm

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 22, 2026

LGTM label has been added.

DetailsGit tree hash: ff49f5bd22dad66c2d0450f577bfc874877ada65

@gardener-prow gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 24, 2026

New changes are detected. LGTM label has been removed.

@gardener-prow gardener-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2026
@gardener-prow gardener-prow Bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takoverflow takoverflow takoverflow left review comments

Assignees

No one assigned

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r4mek @takoverflow @gagan16k @thiyyakat