Skip to content

PHP8.4 Deprecation fix - #63

Open
davisriska wants to merge 2 commits into
gasparesganga:v3from
davisriska:v3
Open

PHP8.4 Deprecation fix#63
davisriska wants to merge 2 commits into
gasparesganga:v3from
davisriska:v3

Conversation

@davisriska

@davisriska davisriska commented Jan 13, 2025

Copy link
Copy Markdown

Fixes PHP 8.4 deprecation warnings/errors

I first tried array|null and ?array but they were added in PHP8.0 and PHP7.1 respectively. So I reviewed what happens with the null and it just gets ignored with the if. I think this fix should work with 5.4.

Shapefile\Geometry\MultiPolygon::__construct(): Implicitly marking parameter $polygons as nullable is deprecated, the explicit nullable type must be used instead
Shapefile\Geometry\GeometryCollection::__construct(): Implicitly marking parameter $geometries as nullable is deprecated, the explicit nullable type must be used instead
Shapefile\Geometry\MultiPolygon::__construct(): Implicitly marking parameter $polygons as nullable is deprecated, the explicit nullable type must be used instead

@Malezha

Malezha commented Apr 1, 2026

Copy link
Copy Markdown

@gasparesganga please consider this pull request as soon as possible, as this is a very critical issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants