Cite ZIP 215 for Ed25519 signature validation criteria - #541
Merged
Conversation
davxy
reviewed
Jul 26, 2026
Co-authored-by: Davide Galassi <davxy@datawok.net>
Contributor
Author
|
@davxy Agreed, thanks |
davxy
approved these changes
Jul 26, 2026
zdave-parity
approved these changes
Aug 3, 2026
gavofyork
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notation.texdefines valid Ed25519 signatures by reference to RFC 8032 alone, butRFC 8032 §5.1.7 explicitly permits two different verification equations:
So validity is not determined by the current text. Two conforming implementations can
disagree on whether a signature is valid, and for assurances, guarantees and judgments
that means disagreeing on whether a block is valid.
This came up implementing verification in
jam-forge: with only RFC 8032 to work from,both the verification equation and the treatment of non-canonical encodings have to be
chosen without guidance, and both are consensus-visible. The vectors in
jam-conformance/crypto/ed25519exist because the answers diverge in practice.