Fix forget host-call incorrectly dropping preimage - #545
Open
zdave-parity wants to merge 1 commit into
Open
Conversation
As we can not know the length of a preimage prior to it being provided, we allow multiple requests with the same hash but differing lengths to be made. Only a request with the correct length can ever be satisfied and transition to a provided state. We must only drop the preimage when we drop a request which is in a provided state. A request in the requested state (empty status sequence) does _not_ imply that we do not have the preimage; its length may be incorrect and another request with the correct length may be in a provided state.
davxy
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we can not know the length of a preimage prior to it being provided, we allow multiple requests with the same hash but differing lengths to be made. Only a request with the correct length can ever be satisfied and transition to a provided state. We must only drop the preimage when we drop a request which is in a provided state. A request in the requested state (empty status sequence) does not imply that we do not have the preimage; its length may be incorrect and another request with the correct length may be in a provided state.