Skip to content

Support negative indexes in the :eq() selector #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support negative indexes in the :eq() selector #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pyquery/cssselectpatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,14 +375,24 @@ def xpath_eq_function(self, xpath, function):
>>> d('h1:eq(1)')
[<h1.last>]

A negative index counts back from the last element::

>>> d('h1:eq(-1)')
[<h1.last>]

..
"""
if function.argument_types() != ['NUMBER']:
raise ExpressionError(
"Expected a single integer for :eq(), got %r" % (
function.arguments,))
value = int(function.arguments[0].value)
xpath.add_post_condition('position() = %s' % (value + 1))
if value < 0:
xpath.add_post_condition(
'position() = last()%s' % (
'%+d' % (value + 1) if value != -1 else ''))
else:
xpath.add_post_condition('position() = %s' % (value + 1))
return xpath

def xpath_gt_function(self, xpath, function):
Expand Down
7 changes: 7 additions & 0 deletions tests/test_pyquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ def test_pseudo_classes(self):
assert len(e(":empty")) == 1
assert len(e(":contains('Heading')")) == 8

def test_eq_negative_index(self):
e = self.klass(self.html)
self.assertEqual(e('div:eq(-1)').text(), 'node3')
self.assertEqual(e('div:eq(-2)').text(), 'node2')
self.assertEqual(e('div:eq(-3)').text(), 'node1')
self.assertEqual(e('div:eq(-4)').text(), '')

def test_on_the_fly_dom_creation(self):
e = self.klass(self.html)
assert e('<p>Hello world</p>').text() == 'Hello world'
Expand Down