[various] Reduce compiler warnings from g_slist_foreach and other common issues - #1589
Open
WrapEarnPass wants to merge 16 commits into
Open
[various] Reduce compiler warnings from g_slist_foreach and other common issues#1589WrapEarnPass wants to merge 16 commits into
WrapEarnPass wants to merge 16 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been testing my plugin in geany for windows. The geany-plugins repo apparently doesn't get a lot of windows maintenance as the windows build is noisy as hell.
I count 54 warnings in the windows build from master. That seems small, but the console spam is horrible after 50 builds in a day.
This changeset gets it down to 30.
I was unable to reduce it any further due to LSP's frequent use of aggregate-return and ignoring sign compares.
I have broken each commit up by each plugin, so you can back out any block you don't want to deal with right now.
Closes #1588
One change that needs special highlighting.
#define _WIN32_WINNT 0x0501was removed from scope/src/thread.cThis shouldn't matter because your build process should be setting _WIN32_WINNT for the entire build in CFLAG.
Closes #1587