[git-changebar] Marker unload fixes, and system color support - #1599
Open
WrapEarnPass wants to merge 2 commits into
Open
[git-changebar] Marker unload fixes, and system color support#1599WrapEarnPass wants to merge 2 commits into
WrapEarnPass wants to merge 2 commits into
Conversation
Add ui element for system color Add handler for system color Add editor-notify abuse to ensure colors are set if system color is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this?
As noted in #1558, when git-changebar unloads, it doesn't cleanup all its markers.
As requested in the same ticket, git-changebar only has one color scheme, but geany supports many. Provide an option to allow git-changebar to use system colors.
As a note, since git-changebar uses markers, and colors are set for lines, I stole the foreground color from
to use as the marker background.
I also had to abuse editor-notify as geany doesn't emit any signals for colorscheme-change.
Fixes #1558
Contributed under GPL-2.0-or-later.