-
Notifications
You must be signed in to change notification settings - Fork 318
IMPACT: set the default maximum_distance based on trt and mag by interpolation
#11459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ptormene
wants to merge
14
commits into
master
Choose a base branch
from
defmaxdist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4089365
If maximum_distance is not specified by the user, it is set based on …
ptormene 3bbbaa9
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene b555e5f
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene 5c07f16
Log the maximum_distance used in the job
ptormene 1bae3e8
Fix pep8
ptormene 6274121
Log also the chosen trt; fix the mosaic command to use the default ma…
ptormene fe30b41
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene acd2f16
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene d52c97a
Minor change to a comment [ci skip]
ptormene 3c0a0ad
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene 7186e56
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene f092465
Set the default maximum_distance based on trt and mag only in the oq-…
ptormene 9840f3a
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene a4da299
Merge remote-tracking branch 'origin/master' into defmaxdist
ptormene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very fragile against future changes. At the minimum we need a test at the mosaic level to be able to maintain this mapping and I bet @mmpagani has an idea about the TRTs at the global scale.