Reuse one USD currency formatter

android/data/coordinators/src/main/kotlin/com/gemwallet/android/data/coordinators/transaction/GetTransactionsImpl.kt

@@ -38,6 +38,8 @@ import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.stateIn
 import java.math.BigInteger
 
+private val usdFiatFormatter = CurrencyFormatter(type = CurrencyFormatter.Type.Fiat, currency = Currency.USD)
+
 class GetTransactionsImpl(
     private val transactionsRepository: TransactionRepository,
     scope: CoroutineScope = CoroutineScope(Dispatchers.IO),
@@ -111,11 +113,11 @@ class TransactionDataAggregateImpl(
                 AmountSign.Incoming.format(formatter.string(value, asset))
             } ?: ""
         }
-        TransactionType.PerpetualOpenPosition -> CurrencyFormatter(type = CurrencyFormatter.Type.Fiat, currency = Currency.USD).string(
+        TransactionType.PerpetualOpenPosition -> usdFiatFormatter.string(
             CryptoFiatConverter.toFiat(Crypto(data.transaction.value), HypercoreUSDC.decimals, price = 1.0).atomicValue,
         )
         TransactionType.PerpetualClosePosition -> pnl?.let {
-            PriceChangeFormatter(CurrencyFormatter(type = CurrencyFormatter.Type.Fiat, currency = Currency.USD)).string(it)
+            PriceChangeFormatter(usdFiatFormatter).string(it)
         } ?: ""
         TransactionType.StakeUndelegate,
         TransactionType.StakeRewards,

android/features/perpetual/presents/src/main/kotlin/com/gemwallet/android/features/perpetual/views/components/PositionProperties.kt

@@ -22,6 +22,8 @@ import com.gemwallet.android.ui.theme.paddingMiddle
 import com.wallet.core.primitives.Currency
 import com.wallet.core.primitives.PerpetualMarginType
 
+private val usdFormatter = CurrencyFormatter(currency = Currency.USD)
+
 internal fun LazyListScope.positionProperties(
     position: PerpetualPositionDetailsDataAggregate?,
     onAutocloseClick: () -> Unit,
@@ -121,5 +123,5 @@ private fun PerpetualMarginType.title(): String {
 }
 
 private fun Double?.formatTriggerOrder(label: String): String? {
-    return this?.let { "$label: ${CurrencyFormatter(currency = Currency.USD).string(it)}" }
+    return this?.let { "$label: ${usdFormatter.string(it)}" }
 }

android/ui/src/main/kotlin/com/gemwallet/android/ui/components/list_item/transaction/TransactionDataAggregateExt.kt

@@ -18,6 +18,8 @@ import com.wallet.core.primitives.TransactionDirection
 import com.wallet.core.primitives.TransactionState
 import com.wallet.core.primitives.TransactionType
 
+private val usdFiatFormatter = CurrencyFormatter(type = CurrencyFormatter.Type.Fiat, currency = Currency.USD)
+
 @Composable
 fun TransactionDataAggregate.getTitle(): String =
     perpetualTitle(type, perpetualDirection) ?: stringResource(type.getTitle(direction, state))
@@ -72,7 +74,7 @@ fun TransactionDataAggregate.formatAddress(): String? = when (type) {
     TransactionType.PerpetualOpenPosition,
     TransactionType.PerpetualClosePosition,
     TransactionType.PerpetualModifyPosition -> perpetualPrice?.let {
-        "${stringResource(R.string.asset_price)}: ${CurrencyFormatter(type = CurrencyFormatter.Type.Fiat, currency = Currency.USD).string(it)}"
+        "${stringResource(R.string.asset_price)}: ${usdFiatFormatter.string(it)}"
     }
     TransactionType.StakeFreeze -> resourceType?.let {
         "${stringResource(id = R.string.transfer_to)} ${stringResource(it.titleRes())}"

ios/Features/Perpetuals/Sources/ViewModels/AutocloseSceneViewModel.swift

@@ -13,16 +13,17 @@ import SwiftUI
 @Observable
 @MainActor
 public final class AutocloseSceneViewModel {
-    private let currencyFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
+    private let currencyFormatter: CurrencyFormatter
     private let percentFormatter = PercentFormatter.signed
     private let perpetualFormatter = PerpetualFormatter(provider: .hypercore)
     private let type: AutocloseType
     private let estimator: AutocloseEstimator
 
     var input: AutocloseInput
 
-    public init(type: AutocloseType) {
+    public init(type: AutocloseType, currencyFormatter: CurrencyFormatter = .usd) {
         self.type = type
+        self.currencyFormatter = currencyFormatter
         estimator = AutocloseEstimator(type: type)
 
         input = AutocloseInput(

ios/Features/Perpetuals/Sources/ViewModels/OpenPositionItemViewModel.swift

@@ -14,9 +14,9 @@ struct OpenPositionItemViewModel: ListAssetItemViewable {
 
     var action: ((ListAssetItemAction) -> Void)?
 
-    init(data: AutocloseOpenData) {
+    init(data: AutocloseOpenData, currencyFormatter: CurrencyFormatter = .usd) {
         self.data = data
-        currencyFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
+        self.currencyFormatter = currencyFormatter
     }
 
     var name: String {

ios/Features/Perpetuals/Sources/ViewModels/PerpetualViewModel.swift

@@ -15,10 +15,14 @@ public struct PerpetualViewModel {
     private let priceFormatter: CurrencyFormatter
     private let percentFormatter = PercentFormatter.signed
 
-    public init(perpetual: Perpetual, currencyStyle: CurrencyFormatterType = .abbreviated) {
+    public init(
+        perpetual: Perpetual,
+        currencyStyle: CurrencyFormatterType = .abbreviated,
+        priceFormatter: CurrencyFormatter = .usd,
+    ) {
         self.perpetual = perpetual
+        self.priceFormatter = priceFormatter
         marketValueFormatter = CurrencyFormatter(type: currencyStyle, currencyCode: Currency.usd.rawValue)
-        priceFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
     }
 
     public var name: String {

ios/Features/Transactions/Sources/ViewModels/TransactionPnlViewModel.swift

@@ -10,9 +10,11 @@ import SwiftUI
 
 struct TransactionPnlViewModel {
     private let metadata: TransactionPerpetualMetadata?
+    private let currencyFormatter: CurrencyFormatter
 
-    init(metadata: TransactionPerpetualMetadata?) {
+    init(metadata: TransactionPerpetualMetadata?, currencyFormatter: CurrencyFormatter = .usd) {
         self.metadata = metadata
+        self.currencyFormatter = currencyFormatter
     }
 }
 
@@ -22,9 +24,8 @@ extension TransactionPnlViewModel: ItemModelProvidable {
             return .empty
         }
 
-        let formatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
         let sign = metadata.pnl >= 0 ? "+" : ""
-        let pnlFormatted = formatter.string(metadata.pnl)
+        let pnlFormatted = currencyFormatter.string(metadata.pnl)
         let color = metadata.pnl >= 0 ? Colors.green : Colors.red
 
         return .pnl(

ios/Features/Transactions/Sources/ViewModels/TransactionPriceViewModel.swift

@@ -8,9 +8,11 @@ import Primitives
 
 struct TransactionPriceViewModel {
     private let metadata: TransactionPerpetualMetadata?
+    private let currencyFormatter: CurrencyFormatter
 
-    init(metadata: TransactionPerpetualMetadata?) {
+    init(metadata: TransactionPerpetualMetadata?, currencyFormatter: CurrencyFormatter = .usd) {
         self.metadata = metadata
+        self.currencyFormatter = currencyFormatter
     }
 }
 
@@ -20,8 +22,7 @@ extension TransactionPriceViewModel: ItemModelProvidable {
             return .empty
         }
 
-        let formatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
-        let priceFormatted = formatter.string(metadata.price)
+        let priceFormatted = currencyFormatter.string(metadata.price)
 
         return .price(
             title: Localized.Asset.price,

ios/Features/WalletTab/Sources/ViewModels/PerpetualsPreviewViewModel.swift

@@ -8,7 +8,7 @@ import Store
 @Observable
 @MainActor
 final class PerpetualsPreviewViewModel {
-    private let currencyFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
+    private let currencyFormatter: CurrencyFormatter
 
     let positionsQuery: ObservableQuery<PerpetualPositionsRequest>
     let walletBalanceQuery: ObservableQuery<PerpetualWalletBalanceRequest>
@@ -21,7 +21,8 @@ final class PerpetualsPreviewViewModel {
         walletBalanceQuery.value
     }
 
-    init(walletId: WalletId) {
+    init(walletId: WalletId, currencyFormatter: CurrencyFormatter = .usd) {
+        self.currencyFormatter = currencyFormatter
         positionsQuery = ObservableQuery(PerpetualPositionsRequest(walletId: walletId), initialValue: [])
         walletBalanceQuery = ObservableQuery(PerpetualWalletBalanceRequest(walletId: walletId), initialValue: .zero)
     }

ios/Features/WalletTab/Sources/ViewModels/PortfolioSceneViewModel.swift

@@ -19,7 +19,7 @@ public final class PortfolioSceneViewModel: ChartListViewable {
     private let currencyFormatter: CurrencyFormatter
     private let priceFormatter: CurrencyFormatter
     private let percentFormatter = PercentFormatter.signed
-    private let perpetualFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
+    private let perpetualFormatter: CurrencyFormatter
 
     var state: PortfolioState
 
@@ -38,10 +38,12 @@ public final class PortfolioSceneViewModel: ChartListViewable {
         service: PortfolioDataService,
         preferences: ObservablePreferences,
         defaultType: PortfolioType = .wallet,
+        perpetualFormatter: CurrencyFormatter = .usd,
     ) {
         self.wallet = wallet
         self.service = service
         self.preferences = preferences
+        self.perpetualFormatter = perpetualFormatter
         let currencyCode = preferences.preferences.currency
         currencyFormatter = CurrencyFormatter(type: .currency, currencyCode: currencyCode)
         priceFormatter = CurrencyFormatter(currencyCode: currencyCode)

ios/Packages/Formatters/Sources/AutocloseFormatter.swift

@@ -9,7 +9,7 @@ public struct AutocloseFormatter: Sendable {
     private let stopLossLabel: String
 
     public init(
-        currencyFormatter: CurrencyFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue),
+        currencyFormatter: CurrencyFormatter = .usd,
         takeProfitLabel: String,
         stopLossLabel: String,
     ) {

ios/Packages/Formatters/Sources/Extensions/CurrencyFormatter+Formatters.swift

@@ -0,0 +1,8 @@
+// Copyright (c). Gem Wallet. All rights reserved.
+
+import Foundation
+import Primitives
+
+public extension CurrencyFormatter {
+    static let usd = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
+}

ios/Packages/PrimitivesComponents/Sources/ViewModels/PerpetualDetailsViewModel.swift

@@ -38,7 +38,7 @@ public struct PerpetualDetailsViewModel: Sendable, Identifiable {
     }
 
     private let type: PerpetualDetailsType
-    private let currencyFormatter = CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue)
+    private let currencyFormatter: CurrencyFormatter
     private let numericFormatter = NumericFormatter()
     private let percentFormatter = PercentFormatter.signed
     private let percentSignLessFormatter = PercentFormatter.unsigned
@@ -47,8 +47,9 @@ public struct PerpetualDetailsViewModel: Sendable, Identifiable {
         stopLossLabel: Localized.Perpetual.stopLoss,
     )
 
-    public init(type: PerpetualDetailsType) {
+    public init(type: PerpetualDetailsType, currencyFormatter: CurrencyFormatter = .usd) {
         self.type = type
+        self.currencyFormatter = currencyFormatter
     }
 
     var data: PerpetualConfirmData {

ios/Packages/PrimitivesComponents/TestKit/PriceChangeViewModel+PrimitivesComponentsTestKit.swift

@@ -9,7 +9,7 @@ public extension PriceChangeViewModel {
     static func mock(value: Double?) -> PriceChangeViewModel {
         PriceChangeViewModel(
             value: value,
-            currencyFormatter: CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue),
+            currencyFormatter: CurrencyFormatter.usd,
         )
     }
 }

ios/Packages/PrimitivesComponents/TestKit/TotalValueViewModel+PrimitivesComponentsTestKit.swift

@@ -13,7 +13,7 @@ public extension TotalValueViewModel {
     ) -> TotalValueViewModel {
         TotalValueViewModel(
             totalValue: .mock(value: value, pnlAmount: pnlAmount, pnlPercentage: pnlPercentage),
-            currencyFormatter: CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue),
+            currencyFormatter: CurrencyFormatter.usd,
         )
     }
 }

ios/Packages/PrimitivesComponents/Tests/PrimitivesComponentsTests/PnLViewModelTests.swift

@@ -37,7 +37,7 @@ extension PnLViewModel {
         PnLViewModel(
             pnl: pnl,
             marginAmount: marginAmount,
-            currencyFormatter: CurrencyFormatter(type: .currency, currencyCode: Currency.usd.rawValue),
+            currencyFormatter: CurrencyFormatter.usd,
             percentFormatter: PercentFormatter.signed,
         )
     }