feat: consolidate to llguidance from xgrammar#1077
Open
jakelorocco wants to merge 3 commits into
Open
Conversation
… instead of xgrammar Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
This was
linked to
issues
May 14, 2026
ajbozarth
reviewed
May 14, 2026
Contributor
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
On a quick read-through this looks good, Claude found a handful of small items, but nothing big:
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
ajbozarth
reviewed
May 18, 2026
Comment on lines
+20
to
27
| from ....core.utils import MelleaLogger | ||
|
|
||
| if TYPE_CHECKING: | ||
| import llguidance | ||
| import torch | ||
| from transformers import PreTrainedModel, PreTrainedTokenizerBase | ||
|
|
||
| # First Party |
Contributor
There was a problem hiding this comment.
nite: import ordering
Suggested change
| from ....core.utils import MelleaLogger | |
| if TYPE_CHECKING: | |
| import llguidance | |
| import torch | |
| from transformers import PreTrainedModel, PreTrainedTokenizerBase | |
| # First Party | |
| if TYPE_CHECKING: | |
| import llguidance | |
| import torch | |
| from transformers import PreTrainedModel, PreTrainedTokenizerBase | |
| # First Party | |
| from ....core.utils import MelleaLogger |
ajbozarth
approved these changes
May 18, 2026
Contributor
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
small nit, otherwise LGTM. Though it may be worth getting a pair of eyes that know the affected code a bit better to double check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Moves granite formatters onto llguidance. There wasn't a strong reason to keep xgrammar and both work. All intrinsic tests continue to pass.
Moved
_GuidanceLogitsProcessorto util so that it could be imported by the HuggingFace backend and not live in two spots.Also fixed one spot in the util function where
modelwas being used even though it could've beenNone.Testing
Attribution