feat(cli): Add log:list CLI command by shrutip90 · Pull Request #6136 · genkit-ai/genkit

shrutip90 · 2026-08-21T00:00:01Z

Add a log:list command similar to trace:list command for listing logs. Allows filtering on the following args:

bash-3.2$ genkit log:list --help
Usage: genkit log:list [options]

list logs

Options:
  -l, --limit <number>          limit the number of returned logs (default: "15")
  --trace-id <id>               filter by trace ID
  --span-id <id>                filter by span ID
  --severity <severity>         filter by severity (e.g., INFO, ERROR, WARNING)
  -f, --format <format>         output format (choices: "text", "jsonl", default: "text")
  --continuation-token <token>  continuation token for pagination
  -h, --help                    display help for command

Sample output:

bash-3.2$ genkit log:list
Error: listen EADDRINUSE: address already in use 127.0.0.1:4033
Found 15 logs:

ID:       cce5e07e-c686-4069-95da-efb18265f796
Severity: INFO
Time:     8/20/2026, 3:52:34 PM
Message:  Input[blockingMiddleware > generate, blockingMiddleware]
Attrs:    logging.googleapis.com/spanId=7f0e86e2c5652248, logging.googleapis.com/trace=projects/shruti-genkit-...
---
ID:       7956edb0-15ac-4a78-a419-fcf698326392
Severity: ERROR
Time:     8/20/2026, 3:52:34 PM

Checklist:

PR title is following https://www.conventionalcommits.org/en/v1.0.0/
PR description contains enough context, bug link, code samples for new APIs
Tested (manually, unit tested, etc.)
Docs/readmes updated

gemini-code-assist

Code Review

This pull request introduces a new log:list command to the CLI, enabling users to retrieve and display logs with filtering options like limit, trace ID, span ID, severity, and pagination. It also updates the telemetry server, log store, and runtime manager to support querying logs by severity text and number, and fixes a minor pluralization issue in the trace:list command. Feedback on the changes suggests handling potential TypeError exceptions in formatBody when stringifying objects with circular references, validating the --limit option to ensure it is a positive integer, and URL-encoding the severityText filter parameter in the runtime manager to prevent query string corruption.

shrutip90 · 2026-08-21T23:24:15Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new log:list CLI command to retrieve and filter logs, along with backend support in the telemetry server, file log store, and runtime manager to filter logs by severity. It also fixes a minor pluralization issue in the trace:list command. The review feedback highlights a few key issues: the /api/logs endpoint should extract and pass traceId and spanId query parameters to support standalone span filtering, the runtime manager needs to append spanId to the query when traceId is absent, and the CLI log formatter should safely check the type of log.timestamp to prevent a valid 0 timestamp from being incorrectly treated as falsy.

gemini-code-assist · 2026-08-21T23:25:51Z

+      const { limit, continuationToken, severityText, severityNumber } =
+        request.query;
      response.json(
        await params.logStore.list({
          limit: limit ? Number.parseInt(limit.toString()) : 100,
          continuationToken: continuationToken
            ? continuationToken.toString()
            : undefined,
+          severityText: severityText ? severityText.toString() : undefined,
+          severityNumber: severityNumber
+            ? Number.parseInt(severityNumber.toString())
+            : undefined,
        })
      );


The /api/logs endpoint does not extract traceId or spanId from the query parameters. If a user filters logs by spanId without providing a traceId, the filter is silently ignored by the server. Extracting these query parameters and passing them to logStore.list ensures that filtering by spanId alone works correctly.

const { limit, continuationToken, severityText, severityNumber, traceId, spanId } = request.query; response.json( await params.logStore.list({ limit: limit ? Number.parseInt(limit.toString()) : 100, continuationToken: continuationToken ? continuationToken.toString() : undefined, severityText: severityText ? severityText.toString() : undefined, severityNumber: severityNumber ? Number.parseInt(severityNumber.toString()) : undefined, traceId: traceId ? traceId.toString() : undefined, spanId: spanId ? spanId.toString() : undefined, }) );

Makes sense?

gemini-code-assist · 2026-08-21T23:25:51Z

+    if (filter?.severityNumber) {
+      if (query !== '') query += '&';
+      query += `severityNumber=${filter.severityNumber}`;
+    }


When filter.traceId is not present but filter.spanId is, the request is routed to /api/logs. We need to append spanId to the query parameters so that the telemetry server can filter by it.

if (filter?.severityNumber) { if (query !== '') query += '&'; query += 'severityNumber=' + filter.severityNumber; } if (filter?.spanId && !filter?.traceId) { if (query !== '') query += '&'; query += 'spanId=' + encodeURIComponent(filter.spanId); }

+1. Can be simplified by treated these independently instead

gemini-code-assist · 2026-08-21T23:25:51Z

+            let time = 'unknown';
+            if (log.timestamp) {
+              time = new Date(log.timestamp).toLocaleString();
+            }


Checking log.timestamp as a truthy value can lead to a bug if the timestamp is 0 (which is a valid timestamp representing the epoch). It is safer to check if the type is a number or if it is not null/undefined.

Suggested change

let time = 'unknown';

if (log.timestamp) {

time = new Date(log.timestamp).toLocaleString();

}

let time = 'unknown';

if (typeof log.timestamp === 'number') {

time = new Date(log.timestamp).toLocaleString();

}

ssbushi · 2026-08-24T15:22:11Z

+  .option('--trace-id <id>', 'filter by trace ID')
+  .option('--span-id <id>', 'filter by span ID')


What is the behaviour if neither of these are specified? Will the most recent logs be printed? Worth documenting, and also worth mentioning that while traceId and spanId are optional, they are recommended to be provided (at least traceId). Not sure if there's any use case where that is not true....

ssbushi · 2026-08-24T15:28:46Z

+        const response = await manager.listLogs(listRequest);
+
+        if (!response || !response.logs || response.logs.length === 0) {
+          logger.info('No logs found.');


Would this log to stdout? If so that may be distruptive in jsonl mode?

ssbushi · 2026-08-24T15:29:33Z

+            let time = 'unknown';
+            if (log.timestamp) {
+              time = new Date(log.timestamp).toLocaleString();
+            }


ssbushi · 2026-08-24T15:35:51Z

+            logger.info(
+              `To get the next page, use: --continuation-token ${response.continuationToken}`
+            );
+          } else {
+            console.log(
+              `\nTo get the next page, use: --continuation-token ${response.continuationToken}`
+            );


Worth mentioning here and in trace-list that user should use log-get or trace-get to fetch the full log?

ssbushi · 2026-08-24T15:37:01Z

+    });
+  });
+
+  it('should output formatted  logs without verbose flag', async () => {


Suggested change

it('should output formatted logs without verbose flag', async () => {

it('should output formatted logs without format flag', async () => {

ssbushi · 2026-08-24T15:38:57Z

+    if (filter?.severityNumber) {
+      if (query !== '') query += '&';
+      query += `severityNumber=${filter.severityNumber}`;
+    }


+1. Can be simplified by treated these independently instead

ssbushi · 2026-08-24T15:43:14Z

+      const { limit, continuationToken, severityText, severityNumber } =
+        request.query;
      response.json(
        await params.logStore.list({
          limit: limit ? Number.parseInt(limit.toString()) : 100,
          continuationToken: continuationToken
            ? continuationToken.toString()
            : undefined,
+          severityText: severityText ? severityText.toString() : undefined,
+          severityNumber: severityNumber
+            ? Number.parseInt(severityNumber.toString())
+            : undefined,
        })
      );


Makes sense?

ssbushi · 2026-08-24T15:44:38Z

+    '--severity <severity>',
+    'filter by severity (e.g., INFO, ERROR, WARNING)'


Is this filtering to that exact severity or to and above? I think the latter is a common pattern for logs

ssbushi · 2026-08-24T15:45:13Z

  traceId: z.string().optional(),
  spanId: z.string().optional(),
+  severityText: z.string().optional(),
+  severityNumber: z.number().optional(),


Curious, who is using severityNumber? The CLI does not seem to be using it?

feat: Add log:list CLI command

634ed26

github-project-automation Bot added this to Genkit Backlog Aug 21, 2026

github-actions Bot added js tooling labels Aug 21, 2026

gemini-code-assist Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread genkit-tools/cli/src/commands/log-list.ts

Comment thread genkit-tools/cli/src/commands/log-list.ts

Comment thread genkit-tools/common/src/manager/manager.ts

Handle GCA comments

309b60c

shrutip90 requested review from pavelgj and ssbushi August 21, 2026 16:34

Replace verbose flag with jsonl format flag

ab71c0a

gemini-code-assist Bot reviewed Aug 21, 2026

View reviewed changes

ssbushi reviewed Aug 24, 2026

View reviewed changes

		.option('--trace-id <id>', 'filter by trace ID')
		.option('--span-id <id>', 'filter by span ID')

	it('should output formatted logs without verbose flag', async () => {
	it('should output formatted logs without format flag', async () => {

		'--severity <severity>',
		'filter by severity (e.g., INFO, ERROR, WARNING)'

Uh oh!

Conversation

shrutip90 commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shrutip90 commented Aug 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shrutip90 commented Aug 21, 2026 •

edited

Loading