feat: climate risk from cmip cordex by jdroenner · Pull Request #18 · geo-engine/BioIS

jdroenner · 2026-07-08T22:55:23Z

No description provided.

coveralls · 2026-07-08T23:04:48Z

coverage: 85.899% (-0.3%) from 86.221% — cmip_cordex into main

ChristianBeilschmidt

Konnte das aus Gründen (Karte) nicht anwenden. Aber hier schon mal meine Kommentare.

ChristianBeilschmidt · 2026-07-09T06:17:56Z

      volumeMounts:
        - name: pgdata
-          mountPath: /var/lib/postgresql/data
+          mountPath: /var/lib/postgresql/18/docker


Warum ist das anders, obwohl sich sonst nichts an der Container-Config geändert hat?

docker-library/postgres#1259

Also ich hab das nochmal versucht aber mit dem neusten Image geht das einfach nicht anders :(

ChristianBeilschmidt · 2026-07-09T06:43:56Z

@@ -0,0 +1 @@
+./backend/rust-toolchain.toml


Coverage am besten > 80% lassen.

ChristianBeilschmidt

Ich konnte jetzt erst einmal nur Code-only anschauen. Müssen noch mal wegen der Daten sprechen.

ChristianBeilschmidt · 2026-08-07T14:25:01Z

+    /// Name of a row property that carries the cell color (hex) for this column.
+    #[serde(default, skip_serializing_if = "Option::is_none")]
+    pub color_field: Option<String>,
+    /// Name of a row property that carries a ready-to-display label for this column.
+    /// When set, the frontend renders it instead of the raw value.
+    #[serde(default, skip_serializing_if = "Option::is_none")]
+    pub label_field: Option<String>,


Check: Sind das validate table schema Felder (https://datapackage.org/standard/table-schema/)

ich hab das nochmal neu gemacht / machen lassen. Es müsste jetzt korrekt sein

ChristianBeilschmidt · 2026-08-07T14:26:10Z

    String,
    Number,
    Integer,
+    Percentage,


Es gibt keinen Percentage-Typ bei TableSchema: https://datapackage.org/standard/table-schema/#field-types

Percentage ist jetzt nur noch ein Units-Helfer und taucht nicht mehr als Table-Schema-Feld-Typ auf. Die Prozent-Anzeige (z.B. "+10 days (+20 %)") läuft über die biois-Extension (labelField/colorField).

ChristianBeilschmidt · 2026-08-07T15:20:16Z

+                </td>
+              }
+            }
+            @case (ColumnType.Percentage) {


Den Typ gibt es ja nicht in TableSchema

das gibt es jetzt nicht mehr

ChristianBeilschmidt · 2026-08-07T15:27:48Z

+                  <mat-chip class="cell-content">
+                    <span
+                      class="color-dot"
+                      [style.background-color]="element[column.colorField]"


Irgendwie fühlt es sich falsch an, eine Spalte mit Farbwerten zu haben.
Evtl. finden wir andere Felder für Metadaten oder müssen eine Extension machen (https://datapackage.org/standard/extensions/).

Die Farb-/Label-Werte sind jetzt hiddenFields und über eine Table-Schema-Extension (biois.display mit kind/labelField/colorField) an die Datenfelder gebunden. Keine sichtbare Farbwert-Spalte mehr.

ChristianBeilschmidt

Alles bis auf Tabelle

ChristianBeilschmidt · 2026-08-17T09:49:20Z

    crs: Crs,
 }

+pub fn nearest_containing<T>(


Gerne kurze Docs

ChristianBeilschmidt · 2026-08-17T09:55:45Z

+/// BioIS-specific metadata for rendering a standard Table Schema field.
+#[derive(Serialize, Deserialize, Debug, Clone)]
+#[serde(rename_all = "camelCase")]
+pub struct BioisTableSchemaExtension {


Suggested change

pub struct BioisTableSchemaExtension {

pub struct BioISTableSchemaExtension {

ChristianBeilschmidt · 2026-08-17T09:57:54Z

+    pub min: f64,
+    pub max: f64,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub occurrence_probability: Option<f64>,


Der Typ serialisiert doch nach String.

ChristianBeilschmidt · 2026-08-17T09:59:35Z

+    pub mean: f64,
+    pub median: f64,
+    pub min: f64,
+    pub max: f64,


Year wird doch auch typisiert, wieso nicht Tage?

ChristianBeilschmidt · 2026-08-17T10:01:09Z

+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub occurrence_probability: Option<f64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub anomaly: Option<f64>,


Ja, aber wieso kein Tage-Typ, damit man in Rust typsicher ist?
Im Table-Schema steht es immerhin im Titel.

ChristianBeilschmidt · 2026-08-17T10:12:52Z

+        "0.1.0"
+    }
+
+    #[allow(clippy::too_many_lines)]


Dann kann also #[allow(clippy::too_many_lines)] weg?

ChristianBeilschmidt · 2026-08-17T10:14:37Z

+    if let Some(items) = schema.get_mut("items").and_then(|i| i.as_object_mut())
+        && let Some(enum_values) = items.get("enum").and_then(|e| e.as_array())
+    {
+        let enum_names: Vec<String> = enum_values
+            .iter()
+            .filter_map(|v| v.as_str())
+            .map(|model_value| {
+                CordexModel::ALL
+                    .iter()
+                    .find(|m| {
+                        serde_json::to_value(m)
+                            .ok()
+                            .and_then(|v| v.as_str().map(|s| s == model_value))
+                            .unwrap_or(false)
+                    })
+                    .map_or_else(
+                        || model_value.to_string(),
+                        |m| {
+                            let props = m.properties();
+                            let scenarios = props
+                                .scenarios
+                                .iter()
+                                .map(|s| s.properties().name)
+                                .collect::<Vec<_>>()
+                                .join(", ");
+                            format!("{} ({})", props.name, scenarios)
+                        },
+                    )
+            })
+            .collect();
+        items.insert(
+            "enumNames".to_string(),
+            serde_json::to_value(enum_names).unwrap_or_default(),
+        );
+    }


Das ist genau der gleiche Code wie bisher.

ChristianBeilschmidt · 2026-08-17T10:17:39Z

+  // Resolve nullable primitives like {"anyOf": [{"$ref": ...}, {"type": "null"}]} to their type
+  if (!type && (schema.anyOf || schema.oneOf)) {
+    const branches = (schema.anyOf ?? schema.oneOf) as JSONSchema[];
+    const nonNull = branches.find(
+      (branch) =>
+        typeof branch !== 'object' ||
+        branch === null ||
+        (branch as BaseJSONSchema)['type'] !== 'null',
+    );
+    if (nonNull) {
+      const resolved = resolveSchemaRef(schema, nonNull);
+      const resolvedType =
+        typeof resolved === 'object' && resolved !== null
+          ? (resolved as BaseJSONSchema)['type']
+          : undefined;
+      if (
+        resolvedType === 'string' ||
+        resolvedType === 'number' ||
+        resolvedType === 'integer' ||
+        resolvedType === 'boolean'
+      ) {
+        return typeFromSchema(resolved);
+      }
+    }
+  }
+


aber sollte man das dann nicht da unten machen, wenn man einmal festgestellt hat !type? Dann macht man mit items das da oben und ohne return FieldType.NestedJson;

ChristianBeilschmidt · 2026-08-17T10:18:52Z

    if (typeof example === 'string') return example;
  }

+  return firstEnumOrFallback(schema, fallback);


Da ist kein doc

ChristianBeilschmidt · 2026-08-17T11:04:40Z

+    @if (type() === FieldType.Boolean) {
+      <mat-checkbox [checked]="value()" (change)="value.set($event.checked)"
+        >True/False</mat-checkbox
+      >
+    } @else {


Das beantwortet nicht die Frage; evtl. eigene Component?

…y→Days rename - Consolidate 56 tests to 39 via table-driven tests (item 9) - Move tests inline into mod.rs, types.rs, compute.rs, workflow.rs; delete tests.rs (item 10) - Document DAYS_PER_JULIAN_YEAR constant (item 11) - Rename Day → Days to reserve Day for a future concrete calendar day type - Extract boolean-field component (item 7) - Move nullable schema resolution to !type guard (item 5) - Add JSDoc to firstEnumOrFallback (item 6) - Add doc comment to nearest_containing (item 1) - Rename to BioISTableSchemaExtension (item 2) - Remove #[allow(clippy::too_many_lines)] via build_inputs/build_outputs extraction (item 3) - Extract model_display_name helper (item 4)

… extracted logging helpers, docs

…ses)

…putation id tracking, DbHandle processor

# Conflicts: # backend/src/handler.rs # backend/src/processes/climate_risk/compute.rs # backend/src/processes/climate_risk/mod.rs # backend/src/processes/climate_risk/types.rs # backend/src/processes/climate_risk/workflow.rs # backend/src/processes/parameters/data_resource.rs # backend/src/processes/parameters/mod.rs # backend/src/processes/parameters/units.rs # backend/src/server.rs # frontend/src/app/create/create.component.spec.ts # frontend/src/app/create/schema-info.ts # frontend/src/app/create/simple-form-field.ts

+
+import { ClimateRiskInputs } from '../models/ClimateRiskInputs';
+import { Response } from '../models/Response';
+import { HttpFile } from '../http/http';


+
+import { ClimateRiskInputs } from '../models/ClimateRiskInputs';
+import { DataResource } from '../models/DataResource';
+import { HttpFile } from '../http/http';


+import { CordexModel } from '../models/CordexModel';
+import { CordexRegion } from '../models/CordexRegion';
+import { PointGeoJsonInput } from '../models/PointGeoJsonInput';
+import { HttpFile } from '../http/http';


+ * Do not edit the class manually.
+ */
+
+import { HttpFile } from '../http/http';


+ * Do not edit the class manually.
+ */
+
+import { HttpFile } from '../http/http';


+ * Do not edit the class manually.
+ */
+
+import { HttpFile } from '../http/http';


+import { ClimateRiskInputs        } from '../models/ClimateRiskInputs';
+import { ClimateRiskOutputs } from '../models/ClimateRiskOutputs';
+import { ClimateRiskProcessParams    } from '../models/ClimateRiskProcessParams';
+import { ClimateVariable } from '../models/ClimateVariable';


 import { Constraints7 } from '../models/Constraints7';
 import { Constraints8 } from '../models/Constraints8';
 import { Constraints9 } from '../models/Constraints9';
+import { CordexModel } from '../models/CordexModel';


 import { Constraints8 } from '../models/Constraints8';
 import { Constraints9 } from '../models/Constraints9';
+import { CordexModel } from '../models/CordexModel';
+import { CordexRegion } from '../models/CordexRegion';


 import { BiodiversitySensitiveAreasProcessParams } from '../models/BiodiversitySensitiveAreasProcessParams';
 import { BooleanField } from '../models/BooleanField';
 import { BoundingBox } from '../models/BoundingBox';
+import { ClimateRiskInputs } from '../models/ClimateRiskInputs';


jdroenner changed the title ~~feat: climeate rist from cmip cordex~~ feat: climate risk from cmip cordex Jul 8, 2026

ChristianBeilschmidt requested changes Jul 17, 2026

View reviewed changes

ChristianBeilschmidt requested changes Aug 7, 2026

View reviewed changes

Integrate CMIP/CORDEX climate-risk analysis

a355028

jdroenner force-pushed the cmip_cordex branch from 4809bbb to a355028 Compare August 13, 2026 14:15

jdroenner added 6 commits August 14, 2026 08:11

fix variables order

a5b4f2e

fix lints

7667534

simplify anomaly selection logic

16deb93

fix lints

d935a92

revert isNullOrUndefined check

4160764

remove the enabled-bydefault stuff

96fe4bf

ChristianBeilschmidt requested changes Aug 17, 2026

View reviewed changes

jdroenner added 14 commits August 21, 2026 22:52

Integrate CMIP/CORDEX climate-risk analysis

c00f12a

fix variables order

c6bd21b

fix lints

be530ae

simplify anomaly selection logic

5542c7d

fix lints

a906918

revert isNullOrUndefined check

e3248f2

remove the enabled-bydefault stuff

4ca0a3e

address reviewer comments: TableSchema rename, ClimatePeriods helper,…

d2c7154

… extracted logging helpers, docs

key execute results by declared scenario output ids (OGC API - Proces…

5e90e82

…ses)

add climate-risk placeholder to OpenAPI spec generation

29a1f74

port climate-risk to credits-enabled main: CONTEXT session token, com…

fead838

…putation id tracking, DbHandle processor

regenerate OpenAPI spec and TypeScript client with climate-risk endpoint

3443289

github-code-quality Bot found potential problems Aug 24, 2026

View reviewed changes

jdroenner changed the base branch from main to v1 August 24, 2026 09:27

jdroenner changed the base branch from v1 to main August 24, 2026 09:27

lints

59d9ea2

		@@ -0,0 +1 @@
		./backend/rust-toolchain.toml No newline at end of file

	pub struct BioisTableSchemaExtension {
	pub struct BioISTableSchemaExtension {

Uh oh!

Conversation

jdroenner commented Jul 8, 2026

Uh oh!

coveralls commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChristianBeilschmidt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristianBeilschmidt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChristianBeilschmidt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

coveralls commented Jul 8, 2026 •

edited

Loading