Conversation
Creating new STAC asset can only be done by PUT not by POST.
asteiner-swisstopo
approved these changes
Mar 19, 2026
Contributor
asteiner-swisstopo
left a comment
asteiner-swisstopo
left a comment
There was a problem hiding this comment.
Nice improvement, thanks. I just had some minor comments/questions.
| # Release 20240313 - Wednesday, March 13th 2024 | ||
|
|
||
| ### API & applications | ||
| ## API & applications |
Contributor
There was a problem hiding this comment.
Makes sense but then it's inconsistent with all the others. Probably could be removed altogether - the section is empty for every release 🤷 I would either remove it everywhere (and sync with the DI team) or leave it as it is.
Contributor
Author
There was a problem hiding this comment.
Ok then I leave it as is
| curl --request POST \ | ||
| --url https://data.geoadmin.ch/api/stac/v1/collections/ch.swisstopo.swisstlmregio/items/swisstlmregio-2020/assets \ | ||
| curl --request PUT \ | ||
| --url https://data.geoadmin.ch/api/stac/v1/collections/ch.swisstopo.swisstlmregio/items/swisstlmregio-2020/assets/fancy_unique_id \ |
Contributor
There was a problem hiding this comment.
The rest of the example uses concrete names (like ch.swisstopo.swisstlmregio), not placeholders. So I would suggest to replace fancy_unique_id with an actual asset name/ID in that collection.
Contributor
There was a problem hiding this comment.
For my understanding, why doesn't Renovate update this accordingly and you had to use npm audit fix?
Contributor
Author
There was a problem hiding this comment.
I have no idea about renovate, @KeeTraxx. I run audit because when I installed the dependencies I had some vulnerabilities warnings.
asteiner-swisstopo
added a commit
that referenced
this pull request
Mar 19, 2026
This is a follow-up of [a PR comment](#128 (comment)). I have noticed that all release pages follow this structure: ```txt - Bug fixes - Announcements: - Announcement 1 - Announcement 2 - [Full changelog][https://link] ``` I see three issues with that: 1. Inconsistent formatting: The heading levels jump from h1 (#) directly to h3 (###). Proper markdown does not skip heading levels. 2. "API & applications": Empty on all pages, not clear what is its purpose. 3. "Bug fixes": It's empty for all pages except 20250514. Removing it along with the "Announcements" reduces the list nesting. To focus on the content, I propose to simplify the structure to this: ```txt - Announcement 1 - Announcement 2 - [Full changelog][https://link] ``` The change in heading levels also requires changing the script for the "All releases" page.
asteiner-swisstopo
added a commit
that referenced
this pull request
Mar 19, 2026
This is a follow-up of [a PR comment](#128 (comment)). I have noticed that all release pages follow this structure: ```txt - Bug fixes - Announcements: - Announcement 1 - Announcement 2 - [Full changelog][https://link] ``` I see three issues with that: 1. Inconsistent formatting: The heading levels jump from h1 (#) directly to h3 (###). Proper markdown does not skip heading levels. 2. "API & applications": Empty on all pages, not clear what is its purpose. 3. "Bug fixes": It's empty for all pages except 20250514. Removing it along with the "Announcements" reduces the list nesting. To focus on the content, I propose to simplify the structure to this: ```txt - Announcement 1 - Announcement 2 - [Full changelog][https://link] ``` The change in heading levels also requires changing the script for the "All releases" page.
asteiner-swisstopo
added a commit
that referenced
this pull request
Mar 19, 2026
This is a follow-up of [a PR comment](#128 (comment)). I have noticed that all release pages follow this structure: ```txt \# Release title \### API & applications \### API - Bug fixes - Announcements: - Announcement 1 - Announcement 2 - [Full changelog][https://link] \### Geodata ``` I see three issues with that: 1. Inconsistent formatting: The heading levels jump from h1 (#) directly to h3 (###). Proper markdown does not skip heading levels. 2. "API & applications": Empty on all pages, not clear what is its purpose. 3. "Bug fixes": It's empty for all pages except 20250514. Removing it along with the "Announcements" reduces the list nesting. To focus on the content, I propose to simplify the structure to this: ```txt \# Release title \## API - Announcement 1 - Announcement 2 - [Full changelog][https://link] \## Geodata ``` The change in heading levels also requires changing the script for the "All releases" page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating new STAC asset can only be done by PUT not by POST.
Also fixed some dependencies vulnerabilities by running
npm audit fixTest link