[WIP] remove shopt&alias to make it work on powershell#131
[WIP] remove shopt&alias to make it work on powershell#131pvgenuchten wants to merge 1 commit intogeopython:masterfrom
Conversation
ae4fa34 to
fa0fc91
Compare
|
@tomkralidis, updated docs for powershell |
justb4
left a comment
There was a problem hiding this comment.
Hm, looks like these changes remove the alias and assume the command is docker compose. This will break for students having docker-compose installed (like me).
Best option is to make the script cross-platform. The $IsWindows var e.g.
and https://redmondmag.com/articles/2020/08/18/cross-platform-powershell-scripts.aspx
|
ah, good to know people are still using docker-compose alternative would be to duplicate the script and rename to _ps.sh @justb4 PR updated |
fa0fc91 to
6426d43
Compare
syntax: bash geopython-workshop-ctl.sh start
6426d43 to
1b625d8
Compare
| docker compose rm --force | ||
| elif [ $1 == "url" ]; then | ||
| # try to open the Jupyter Notebook in Browser | ||
| platform="$(uname | tr '[:upper:]' '[:lower:]')" |
There was a problem hiding this comment.
is this still required? I guess the openapp="cmd /c start" is the command in PS here.
|
I cannot test this, but seems useful. I wonder if the |
|
Bumping @pvgenuchten in case we want to add this for FOSS4 EU 2025. |
|
superseded by #203 |
PR to facilitate discussion on this topic
docker-compose was removed >1 year ago, i think we can assume all are migrated by now?
removing shopt and alias because it is not supported on powershell/windows
todo: update docs for windows:
syntax: bash geopython-workshop-ctl.sh start|stop|url|update