fix: add missing mode field to Convex where validators#326
Conversation
Better Auth now sends a mode (sensitive | insensitive) field in where clauses. The Convex validators rejected it as an unexpected field, causing 111 test failures. Add mode as an optional field to both adapterWhereValidator and whereValidator.
|
@rit3sh-x is attempting to deploy a commit to the Convex Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo validator schemas are updated to include an optional Changes
Possibly related issues
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
How fast can this be merged? |
|
Thanks for this - closing in favor of #323. |
Summary
causing 111 test failures
Changes
Test plan
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this
contribution, under the terms of your choice.
Summary by CodeRabbit
modeparameter to specify case-sensitive ("sensitive") or case-insensitive ("insensitive") string matching.