Skip to content

fix(cross-domain): follow redirect on linkSocial callbacks (no newSession) #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mishafyi wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(cross-domain): follow redirect on linkSocial callbacks (no newSession) #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/plugins/cross-domain/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,13 @@ export const crossDomain = ({ siteUrl }: { siteUrl: string }) => {
// Mostly copied from the one-time-token plugin
const session = ctx.context.newSession;
if (!session) {
// linkSocial callbacks have no newSession — the user is already
// signed in. Follow the provider redirect without the
// one-time-token flow instead of dead-ending with an error.
const redirectTo = ctx.context.responseHeaders?.get("location");
if (redirectTo) {
throw ctx.redirect(redirectTo);
}
ctx.context.logger.error("No session found");
return;
}
Expand Down