🎯 fix: Unable to create order for existing customers without billing email

[devAsadNur]

• Fixes: https://github.com/getdokan/plugin-internal-tasks/issues/398

Before:

After:

Error alert for missing billing paramerter has been removed.

Summary by CodeRabbit

• New Features
  • Improved the system so that when a customer’s email is available and the billing email isn’t yet set, the billing email is automatically populated. This adjustment enhances data consistency and streamlines the user experience when managing billing details.

[coderabbitai]

Walkthrough

The change introduces a condition in the selectCustomer method of the Home component. When selecting a customer, the method now checks if the customer object has an email property and if the billing object lacks it. If both conditions are met, it assigns the customer's email to the billing email. The method then continues to dispatch the setCustomerAction, preserving its original functionality.

Changes

File	Change Summary
assets/.../Home.vue	Added a conditional check in the selectCustomer method to verify if customer.email exists and customer.billing.email is undefined, then sets it; dispatch call remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Home as Home Component
    participant Customer as Customer Object
    participant Billing as Billing Object
    participant Store as Vuex Store

    Home->>Customer: selectCustomer(customer)
    alt Customer has email & Billing.email is unset
        Customer->>Billing: set billing.email = customer.email
    end
    Home->>Store: dispatch setCustomerAction

Loading

Poem

Oh, how my hops are light and free,
When code flows with clarity to see,
An email check hops in with grace,
Aligning billing in its proper place,
I nibble bytes with joy today,
A rabbit’s cheer in code display!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between babdb26 and 4953437.

📒 Files selected for processing (1)

• assets/src/frontend/components/Home.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: e2e_api tests

🔇 Additional comments (1)

assets/src/frontend/components/Home.vue (1)

1095-1098: Good fix for handling missing billing email!

This change resolves the issue by automatically copying the customer's email to the billing email when it's missing, ensuring orders can be successfully created for existing customers.

Some considerations:

• The logic properly checks both conditions before making the assignment
• The fix maintains the existing flow by modifying the customer object before dispatching it to the store

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dev-shahed]

@devAsadNur If the user does not provide a first or last name along with the billing email, the search box appears empty when selecting the customer email for payment, Have a look here: https://prnt.sc/RHu5vScsNpvD

[devAsadNur]

@devAsadNur If the user does not provide a first or last name along with the billing email, the search box appears empty when selecting the customer email for payment, Have a look here: https://prnt.sc/RHu5vScsNpvD

• Addressed in another PR: Enhance/select email for customer without name #177