Fixing quote functionality, adding quote icon to the comment editor#1504
Open
JimKnoxx wants to merge 1 commit intogetfider:mainfrom
Open
Fixing quote functionality, adding quote icon to the comment editor#1504JimKnoxx wants to merge 1 commit intogetfider:mainfrom
JimKnoxx wants to merge 1 commit intogetfider:mainfrom
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1500
In #1495 a XSS vulnerability was fixed by sanitizing the editor output. This broke quoting.
I propose to only quote the
<character in this case, so quoting still remain in tact. I am unsure though, if this would open possible xss vulnerabilities again.Also adding a dedicated quoting button to the editor for better UX.