Draft
Conversation
0c797f4 to
87f951d
Compare
1c45c74 to
002f8ed
Compare
002f8ed to
6d81fa8
Compare
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
|
What is holding this PR back? I really need kin-openapi to properly validate nullable enums. :( |
Collaborator
Author
|
@bhechinger From #230 we most probably will move to use https://github.com/qri-io/jsonschema instead of the lib in this PR. I didn't start work on this yet.. maybe give it a shot? |
|
@fenollp I'll take a look. If it's not going to be too much work to get done I may actually be able to make it a pre-req for my current task at work. :) |
|
Due to our current timeline crunch I won't have time for this right now. However, I was instructed to open a tech debt ticket to track this and come back to it later. If this hasn't been done by someone else in the next several months I will do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect schema validation:
Changes
formatsupport:Also: