fix(quotes): underscore charge override properties keys - #6328
Merged
Merged
Conversation
toommz
marked this pull request as ready for review
September 8, 2026 11:18
Contributor
|
Automated pre-review (advisory, not a required check) — verdict: PASS · CI green PASS — Camel-case charge properties are normalized consistently at validation and execution, including inherited amendment paths, while customer-defined custom property keys remain untouched. The focused specs cover recursive conversion, validation, and persisted override behavior; no blocking issues found. |
vincent-pochet
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving tier changes on a quote subscription override failed with
missing_graduated_ranges:billing_itemsis camelCase, but charge overridepropertiesreaches the charge models andCharges::OverrideService, which read snake_case.Utils::ChargeProperties.underscore_keysnow normalizes those properties where they are consumed (validator and execution), leavingcustom_propertiesuntouched. Storage stays as the frontend sent it, and both casings are accepted.Without this an approved quote also dropped the charge from the override plan silently, billing nothing for it.
LAGO-1918