feat(payments): generate payments list filters - #27
Draft
sarkissianraffi wants to merge 2 commits into
Draft
sarkissianraffi wants to merge 2 commits into
sarkissianraffi wants to merge 2 commits into
Conversation
Advance the pinned OpenAPI snapshot to the payments filter spec and regenerate the command descriptors, reference docs and man pages. No handwritten flags or response changes.
This was referenced Sep 7, 2026
Regenerated from the updated OpenAPI bundle: the Lago API removed the filter for performance reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Advance spec/openapi.yaml to the payment filter OpenAPI commit and regenerate command descriptors, operations.json, reference docs and both payment man pages. All requested flags appear on
lago payments list, with equivalent filters onlago customers payments. No flags or mapping tables added by hand.Why
Finance can use the same payment predicate in the CLI, public API and UI. The pinned spec is temporarily ahead of the published snapshot; the daily drift job will reconcile after the OpenAPI PR merges and publishes. Source commit: 1cb1dd67552d07279e74f005ac28d3e9684a76f7; SHA-256 edc85fddf229feb79974e65bb8c7a1a8e720926cb294d3749e6bd572edb72d7d.
Verification
make test(race enabled)make coveragemake lintmake securitymake generate-checkmake build,make test-e2e-compile, CI policy and fixture checksLive CLI checks:
payments list --payment-status succeeded --currency EURreturns seven identical IDs to UI/REST/all SDKs; comma-separated statuses return 14; card/sepa_debit methods return five; maximum int64 bound returns two; the customer-scoped command returns two. Local HTTP uses the explicit self-hosted --insecure option.API and client QA, 79 HTTP assertions, cross-client IDs, UI QA and recording
Related PRs
Merge order: API, then front; OpenAPI before client/CLI releases. JavaScript CI uses the pinned feature spec during that rollout.
Performance follow-up (2026-09-09)
--payment-method-typeremoved fromlago payments listandlago customers payments: the Lago API dropped thepayment_method_typelist filter for performance reasons (getlago/lago-api#6325, "Not shipped for performance reasons"). Regenerated from the updated OpenAPI bundle (getlago/lago-openapi#579); every other flag is unchanged. Indexes for the remaining filters ship first in getlago/lago-api#6341.