Conversation
ansmonjol
marked this pull request as ready for review
September 7, 2026 13:21
|
Contributor
|
Automated pre-review (advisory, not a required check) — verdict: PASS · CI green PASS — The tightened debounce contract is consistent across callers, paginated searches reset before execution, and the ComboBox and Apollo helper refactors preserve their edge-case behavior. Coverage exercises normalization, cancellation/loading timing, removed and free-form options, cache policies, and list search/reset call sites; no blocking findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check selected-value membership directly when combobox options change, avoiding a full deletion diff while preserving free-form values.
Require a string handler from the search hook and express its minimum spinner duration in milliseconds. Share pagination cache-key construction across the two named policies to remove duplication while retaining their existing append and replace behavior.
Exercise list search entry and clearing to ensure each page resets to page 1 before forwarding the input.