Skip to content

fix(tests): expose hidden warnings and complete affected fixtures - #4273

Open
ansmonjol wants to merge 2 commits into
mainfrom
fix/slop-12
Open

ansmonjol wants to merge 2 commits into
mainfrom
fix/slop-12

Conversation

@ansmonjol

Copy link
Copy Markdown
Contributor

Remove broad Apollo and React console suppression while retaining named deprecation and browser-environment exceptions. Forward opaque diagnostic payloads safely and preserve the jsdom navigation exception across JavaScript realms.

Complete affected GraphQL and component mocks, await translation and form lifecycles, and assert expected errors locally so missing data and unfinished updates stay visible. Normalize equivalent GraphQL comments to avoid duplicate fragment warnings.

@ansmonjol
ansmonjol marked this pull request as ready for review September 7, 2026 13:22
@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor

Automated pre-review (advisory, not a required check) — verdict: PASS · CI green

PASS — The console setup now forwards Apollo, mock, cache, and React diagnostics through narrow, tested filters; the fixture updates are consistent, preserve coverage, and all 126 changed suites pass.

@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor

Automated pre-review (advisory, not a required check) — verdict: PASS · CI green

PASS — the warning filter now forwards actionable Apollo/React diagnostics while retaining narrowly scoped environment/deprecation exceptions, with direct coverage for both paths.

Affected fixtures, duplicate fragment definitions, and async tests are updated consistently; all 126 changed suites plus type and lint checks pass without weakened assertions.

@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@lago-claude-ai-agent

Copy link
Copy Markdown
Contributor

Automated pre-review (advisory, not a required check) — verdict: PASS · CI green

PASS — Jest now forwards previously hidden Apollo, GraphQL, and React diagnostics while retaining only narrowly scoped environment/deprecation suppressions, with focused regression coverage for both forwarding and suppression. The affected tests consistently complete mocks and fixtures, await asynchronous behavior, preload contextual locales, and preserve existing ref contracts; application-code changes are comment-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant