feat(contracts): add contracts list page and navigation entry - #4311
Draft
michaelponrajah wants to merge 2 commits into
Draft
michaelponrajah wants to merge 2 commits into
michaelponrajah wants to merge 2 commits into
Conversation
Add a paginated contracts list at /contracts and a placeholder details route at /contracts/:id, both gated on the contractsView permission and the ProductCatalog feature flag, plus a Contracts entry in the main nav and its icon. Pagination follows the billable metrics list: PaginatedContent with its sticky defaults and insetPager, and the table's -mb-px overlap so the last row's border and the pager share one divider. No per-page class overrides, so the shared Pagination components are untouched. The details page is an untranslated "Todo" placeholder pending its own scope. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The details route's registration was asserted but the list route's was not, so dropping `featureFlag: ProductCatalog` or the `contractsView` permission from /contracts would have left the suite green while making the page reachable by URL for any organisation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
michaelponrajah
force-pushed
the
feat/contracts-navigation
branch
from
September 16, 2026 16:55
ee8ac36 to
0126a95
Compare
michaelponrajah
changed the base branch from
main
to
chore/regenerate-graphql-schema
September 16, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Contracts already exist in the schema, with a status mapping landed in #4298 and detail alignment in #4308, but there is no list view and no way to reach contracts from the main navigation. This adds that surface.
Description
/contractslist page (src/pages/contracts/ContractsPage.tsx) — paginated table showing status, name (falling back to external ID), customer, start and end dates, with rows linking through to the details route./contracts/:iddetails route — currently a placeholder; real content comes in a follow-up.contractsViewpermission and theProductCatalogfeature flag.contracticon in the design system.BillableMetricsList:PaginatedContentwith its sticky defaults plusinsetPager, and the table's-mb-pxoverlap so the last row's border and the pager share a single divider. No per-page class overrides — the shared Pagination components are untouched.Known gaps (why this is a draft)
ContractDetailsrenders a hardcoded, untranslated"Todo". Needs real copy viapnpm translations:addbefore review.Verification
pnpm types,pnpm lint(0 errors, only pre-existing formik warnings),pnpm translations:inspectandpnpm translations:ensure-consistencyall pass.src/pages/contractsandsrc/components/designSystem/Pagination.Fixes LAGO-XXX
🤖 Generated with Claude Code