Skip to content

[ING-483] misc(cache): Stop eager charge cache expiration #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent-pochet merged 1 commit into from
Sep 14, 2026
+4 −382
Merged

[ING-483] misc(cache): Stop eager charge cache expiration #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions events-processor/models/charge_cache.go
View file
Open in desktop

This file was deleted.

69 changes: 0 additions & 69 deletions events-processor/models/charge_cache_test.go
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions events-processor/processors/events_processor/cache_service.go
View file
Open in desktop

This file was deleted.

192 changes: 0 additions & 192 deletions events-processor/processors/events_processor/cache_service_test.go
View file
Open in desktop

This file was deleted.

7 changes: 1 addition & 6 deletions events-processor/processors/events_processor/processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,13 @@ type EventProcessor struct {
EnrichmentService *EventEnrichmentService
ProducerService *EventProducerService
RefreshService *SubscriptionRefreshService
CacheService *CacheService
}

func NewEventProcessor(enrichmentService *EventEnrichmentService, producerService *EventProducerService, refreshService *SubscriptionRefreshService, cacheService *CacheService) *EventProcessor {
func NewEventProcessor(enrichmentService *EventEnrichmentService, producerService *EventProducerService, refreshService *SubscriptionRefreshService) *EventProcessor {
return &EventProcessor{
EnrichmentService: enrichmentService,
ProducerService: producerService,
RefreshService: refreshService,
CacheService: cacheService,
}
}

Expand Down Expand Up @@ -157,9 +155,6 @@ func (processor *EventProcessor) processEvent(ctx context.Context, event *models
if flagResult.Failure() {
return failedResult(flagResult, "flag_subscription_refresh", "Error flagging subscription refresh")
}

// Expire cache at charge and charge filter level
processor.CacheService.ExpireCache(ctx, enrichedEvents)
}

return utils.SuccessResult(enrichedEvent)
Expand Down
2 changes: 0 additions & 2 deletions events-processor/processors/events_processor/processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ func setupProcessorTestEnv(t *testing.T, useCache bool) *ProcessorTestEnv {

testProducers := setupProducers()
chargeCache = &tests.MockCacheStore{}
chargeCacheStore := models.NewChargeCache(&chargeCache)
flagStore := tests.MockFlagStore{}
flagger := NewSubscriptionRefreshService(&flagStore)

Expand All @@ -197,7 +196,6 @@ func setupProcessorTestEnv(t *testing.T, useCache bool) *ProcessorTestEnv {
NewEventEnrichmentService(apiStore, memCache),
testProducers.producerService,
flagger,
NewCacheService(chargeCacheStore),
)

return &ProcessorTestEnv{
Expand Down
Loading
Loading