Android auto update changes#8813
Open
jigar-f wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the app’s update-check flow by expanding the Flutter Updater to support Android sideload updates alongside existing desktop auto-updates, refactoring the Android sideload updater implementation (networking, semver comparison, dialogs/telemetry), and adding new i18n strings to support the new update UI.
Changes:
- Add direct Dart dependencies (
http,pub_semver) to support Android sideload update networking and version comparison. - Refactor Android sideload update checking/install prompting (HTTP POST to update endpoint, semver parsing, dialogs/notifications, telemetry logging).
- Add new update-related localization strings across supported
.pofiles and refactor AndroidMethodHandlererror handling/readability.
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pubspec.yaml |
Adds http and pub_semver as direct dependencies for update checking/version comparison. |
pubspec.lock |
Updates lockfile to reflect new direct dependencies. |
lib/core/updater/updater.dart |
Extends updater logic to treat Android as a supported platform and routes manual checks appropriately. |
lib/core/updater/android_sideload_updater.dart |
Major refactor: HTTP-based update fetch, semver parsing via pub_semver, UI dialogs/notifications, install flow + telemetry. |
lib/core/common/app_urls.dart |
Centralizes the Android sideload update endpoint URL. |
assets/locales/*.po |
Adds new update-flow strings (e.g., Update now/Later/Up to date/check failures). |
android/app/src/main/kotlin/org/getlantern/lantern/handler/MethodHandler.kt |
Refactors several method handlers to use runCatching and improves formatting/readability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and code readability in the Android
MethodHandlerclass and adds new update-related strings to multiple localization files to support new update flows in the app.Android error handling and code improvements:
MethodHandler.ktto userunCatchingand.onFailurefor more consistent and concise error reporting, replacing manual try/catch blocks. This improves maintainability and ensures all errors are reported in a standardized way. [1] [2] [3] [4] [5]MethodHandlerclass for cleaner structure.Localization and update flow support: