-
Notifications
You must be signed in to change notification settings - Fork 0
unbounded: WebRTC widget-proxy integration as a parallel peer source #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myleshorton
wants to merge
12
commits into
fisk/peer-manual-portforward
Choose a base branch
from
fisk/peer-unbounded-integration
base: fisk/peer-manual-portforward
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ed6a40c
unbounded: integrate broflake widget-proxy lifecycle manager
844e98f
unbounded/backend: address Copilot review on #501
myleshorton b672141
unbounded/ipc/backend: address Copilot review on #501 (round 2)
myleshorton 4e6bbb5
unbounded/ipc: address Copilot review on #501 (round 3)
myleshorton 89bbcae
unbounded: seed cached config + add lifecycle tests
myleshorton a5bb1ab
unbounded/ipc: address Copilot review on #501 (round 5)
myleshorton b1d4bae
unbounded: restart on config-param change + drop round-X refs
myleshorton fab127d
unbounded: re-check predicate inside start + test event bridge
myleshorton cdfb4e8
unbounded: bound internal stop with a default timeout
myleshorton 11aa55a
backend/unbounded: test PatchSettings dispatches UnboundedKey
myleshorton 6987deb
unbounded: validate cfg URLs + drain post-cancel callbacks
myleshorton 242bca9
unbounded: drop code-location refs from comments
myleshorton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package unbounded | ||
|
|
||
| // countingWidget is a fakeWidget variant whose Stop runs a caller- | ||
| // supplied callback before returning. Used by TestStartDuringStop | ||
| // to decrement the live-widget counter under the test's own gate. | ||
|
myleshorton marked this conversation as resolved.
Outdated
|
||
| type countingWidget struct { | ||
| onStop func() | ||
| } | ||
|
|
||
| func (w *countingWidget) Stop() { | ||
| if w.onStop != nil { | ||
| w.onStop() | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.