fix: set cookie secure flag to false in dev config#1027
Open
emimoir wants to merge 1 commit intogetprobo:mainfrom
Open
fix: set cookie secure flag to false in dev config#1027emimoir wants to merge 1 commit intogetprobo:mainfrom
emimoir wants to merge 1 commit intogetprobo:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The dev config uses http://localhost:8080 (plain HTTP), but both session cookies had secure: true, which tells browsers to only send cookies over HTTPS. This caused a sign-in loop where authentication succeeded but the browser dropped the cookie, redirecting back to login. This change sets secure: false for both cookie configurations in the dev config only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Emily Moir <emi@emimoir.com>
emimoir
force-pushed
the
fix/dev-cookie-secure-flag-v2
branch
from
8dc91e8 to
70ab3fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev config (
cfg/dev.yaml) useshttp://localhost:8080(plain HTTP), but the session cookie hadsecure: true, which tells browsers to only send cookies over HTTPS. This caused a sign-in loop where authentication succeeded but the browser dropped the cookie, redirecting back to login.This change sets
secure: falsefor the cookie configuration in the dev config only.Summary by cubic
Set session cookies secure=false in
cfg/dev.yamlto match http://localhost:8080 and fix the sign-in loop caused by browsers dropping HTTPS-only cookies in dev. Dev-only; production config unchanged.Written for commit 70ab3fa. Summary will update on new commits.