Skip to content

fix: remove content-type from headers in _add_from_file to avoid RuntimeError #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliosuas wants to merge 5 commits into
base: master
Choose a base branch
from
+86 −1
Open

fix: remove content-type from headers in _add_from_file to avoid RuntimeError #791

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f514023
fix: remove content-type from headers in _add_from_file to avoid Runt…
juliosuas Mar 30, 2026
806fb9c
test: add regression test for Content-Type conflict in _add_from_file
juliosuas Apr 1, 2026
9da6a2b
test: use mismatched Content-Type values to verify content_type prece…
juliosuas Apr 2, 2026
a9ecf8c
fix(test): use .yaml extension so _add_from_file selects YAML loader
juliosuas Apr 2, 2026
da3edf3
fix(test): clean up .yaml/.toml fixture variants in teardown_method
juliosuas Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion responses/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,12 +856,25 @@ def _add_from_file(self, file_path: "Union[str, bytes, os.PathLike[Any]]") -> No

for rsp in data["responses"]:
rsp = rsp["response"]
headers = rsp["headers"] if "headers" in rsp else None

# The recorder stores ``content_type`` as a top-level key AND may
# also capture a ``content-type`` / ``Content-Type`` entry inside
# ``headers``. Passing both to ``add()`` raises a RuntimeError.
# Resolve the conflict by removing the header entry so the
# dedicated ``content_type`` kwarg takes precedence, which is the
# behaviour recommended by the library.
if headers is not None and "content_type" in rsp:
headers = {k: v for k, v in headers.items() if k.lower() != "content-type"}
if not headers:
headers = None

self.add(
method=rsp["method"],
url=rsp["url"],
body=rsp["body"],
status=rsp["status"],
headers=rsp["headers"] if "headers" in rsp else None,
headers=headers,
content_type=rsp["content_type"],
auto_calculate_content_length=rsp["auto_calculate_content_length"],
)
Expand Down