Skip to content

Data collected updates#17753

Open
geoffg-sentry wants to merge 4 commits into
masterfrom
data-collected-updates
Open

Data collected updates#17753
geoffg-sentry wants to merge 4 commits into
masterfrom
data-collected-updates

Conversation

@geoffg-sentry
Copy link
Copy Markdown
Contributor

@geoffg-sentry geoffg-sentry commented May 13, 2026

DESCRIBE YOUR PR

Adding clarification in Data Collected for Request Query String across relevant SDKs. Calling out more clearly how this interacts with sendDefaultPii. See getsentry/sentry-conventions#373 for additional detials

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sentry-docs Ready Ready Preview, Comment May 13, 2026 7:45pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
develop-docs Ignored Ignored Preview May 13, 2026 7:45pm

Request Review

@geoffg-sentry
Copy link
Copy Markdown
Contributor Author

geoffg-sentry commented May 13, 2026

check external links failure is pre-existing, unrelated to this change. HTTPHeaderSanitizer.swift was moved. I fixed it.

Copy link
Copy Markdown
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some missing SDK docs. I opened another PR on top of this one to add those too: #17755

Also looks like we might be able to skip ruby here.

Comment thread docs/platforms/ruby/common/data-management/data-collected.mdx
@adinauer
Copy link
Copy Markdown
Member

Here's another PR on top in case we want to also have the more generic wording for SDKs where we added a new sentence that reads like only spans are affected: #17756

@codeowner-assignment codeowner-assignment Bot requested a review from a team May 13, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants