feat(nuxt): Emit low cardinality db span names - #23605
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8524d24. Configure here.
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-nuxt-low-card-db-span-names6
branch
from
August 27, 2026 16:28
8524d24 to
333e1e3
Compare
Lms24
changed the title
Lms24
marked this pull request as ready for review
August 27, 2026 16:32
Lms24
requested review from
chargome and
s1gr1d
and removed request for
a team
August 27, 2026 16:32
Lms24
marked this pull request as draft
August 27, 2026 16:33
Lms24
force-pushed
the
lms/feat-nuxt-low-card-db-span-names6
branch
from
August 28, 2026 12:28
333e1e3 to
3a46f48
Compare
Lms24
marked this pull request as ready for review
August 28, 2026 13:35
Lms24
commented
Aug 28, 2026
Member
Author
There was a problem hiding this comment.
this file has span name adjustments (besides the span streaming conversion)
Member
Author
There was a problem hiding this comment.
this file has span name adjustments (besides the span streaming conversion)
Lms24
force-pushed
the
lms/feat-nuxt-low-card-db-span-names6
branch
from
August 31, 2026 16:43
5ae518d to
311f1d2
Compare
Contributor
s1gr1d
approved these changes
Sep 1, 2026
| const clientSpansPromise = collectStreamedSpans('nuxt-3', spans => { | ||
| return ( | ||
| spans.some(span => span.name === '/test-param/user/:userId()' && span.is_segment) && | ||
| spans.some(span => span.name === `GET /api/user/${PARAM}` && getSpanOp(span) === 'http.client') |
Member
There was a problem hiding this comment.
heads up that some span.names are not low cardinality here (all with ${PARAM}, but not sure if this is part of this PR as the PR is just about db spans
Member
Author
There was a problem hiding this comment.
I think this should be addressed with #23682 since these are http.client spans. Will rebase and check if CI still passes
With span streaming, `db0` query spans are named after their `db.query.summary` (`SELECT users`) instead of the full SQL statement, and report that summary as a new `db.query.summary` attribute. The statement is sanitized before it is summarized, so a string literal containing `from`/`join` cannot leak a value into the name. db0 reports no db system, so a statement that cannot be summarized falls back to `db.namespace` and then to the static `Database operation`. `traceLifecycle: 'static'` keeps the existing names. Refs #23523 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-nuxt-low-card-db-span-names6
branch
from
September 1, 2026 13:13
311f1d2 to
c49da01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
db0query spans are named afterdb.query.summarySELECT * FROM users WHERE id = ?becomesSELECT usersdb.namespace, then toDatabase operationdb.query.summaryattribute, set in both trace lifecyclestraceLifecycle: 'static'keeps the existing namesI converted the
nuxt-3e2e test app to span streaming since there were no other tests testing database instrumentation. This produced quite a few changes to the test app unrelated to span name changes. I audited all of them for correctness but would of course appreciate a 2nd pair of eyes. I did mark the two test files in this PR that actually test against the span name changes.Refs #23523