Skip to content

fix(wasm): Match engine-named wasm frames to the single buffer module - #23662

Draft
andreiborza wants to merge 1 commit into
ab/wasm-nonstreaming-registrationfrom
ab/wasm-firefox-fallback
Draft

fix(wasm): Match engine-named wasm frames to the single buffer module#23662
andreiborza wants to merge 1 commit into
ab/wasm-nonstreaming-registrationfrom
ab/wasm-firefox-fallback

Conversation

@andreiborza

@andreiborza andreiborza commented Aug 26, 2026

Copy link
Copy Markdown
Member

What

Frames of buffer-compiled modules can carry a name the SDK cannot predict: Firefox derives it from the compile call site, and V8 hashes the content of modules at or below 16383 bytes. Such frames now resolve to the registered module when exactly one distinct module was compiled from raw bytes.

Why

Without this, non-streaming symbolication misses Firefox entirely and small modules on V8.

Related: #19564

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 28.56 kB - -
@sentry/browser - with treeshaking flags 26.92 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB - -
@sentry/browser (incl. Tracing) 48.75 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.76 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.68 kB - -
@sentry/browser (incl. Tracing, Replay) 88.23 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.63 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.93 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.85 kB - -
@sentry/browser (incl. Feedback) 46.05 kB - -
@sentry/browser (incl. sendFeedback) 33.62 kB - -
@sentry/browser (incl. FeedbackAsync) 38.73 kB - -
@sentry/browser (incl. Metrics) 29.51 kB - -
@sentry/browser (incl. Logs) 29.8 kB - -
@sentry/browser (incl. Metrics & Logs) 30.43 kB - -
@sentry/react 30.3 kB - -
@sentry/react (incl. Tracing) 50.94 kB - -
@sentry/vue 35.73 kB - -
@sentry/vue (incl. Tracing) 51.02 kB - -
@sentry/svelte 28.59 kB - -
CDN Bundle 30.35 kB - -
CDN Bundle (incl. Tracing) 49.38 kB - -
CDN Bundle (incl. Logs, Metrics) 32.58 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 51.25 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.17 kB - -
CDN Bundle (incl. Tracing, Replay) 86.86 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.73 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.8 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.64 kB - -
CDN Bundle - uncompressed 89.95 kB - -
CDN Bundle (incl. Tracing) - uncompressed 147.2 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.24 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.89 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.41 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 266.69 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.37 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 280.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 286.06 kB - -
@sentry/nextjs (client) 53.56 kB - -
@sentry/sveltekit (client) 49.19 kB - -
@sentry/core/server 65.7 kB - -
@sentry/core/browser 51.86 kB - -
@sentry/node 123.77 kB +0.02% +18 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.53 kB - -
@sentry/node - without tracing 88.03 kB +0.02% +15 B 🔺
@sentry/node - without channel injection 103.18 kB +0.02% +19 B 🔺
@sentry/aws-serverless 96.42 kB +0.03% +27 B 🔺
@sentry/cloudflare (withSentry) - minified 201.04 kB - -
@sentry/cloudflare (withSentry) 500.26 kB - -

View base workflow run

@andreiborza
andreiborza force-pushed the ab/wasm-firefox-fallback branch from cf3c40e to 3eb5ff5 Compare August 27, 2026 12:19
@andreiborza
andreiborza force-pushed the ab/wasm-firefox-fallback branch from 3eb5ff5 to 38529d5 Compare August 27, 2026 14:01
@andreiborza andreiborza changed the title fix(wasm): Match Firefox call-site-derived wasm frames to the single buffer module fix(wasm): Match engine-named wasm frames to the single buffer module Aug 27, 2026
@andreiborza
andreiborza force-pushed the ab/wasm-firefox-fallback branch from 38529d5 to ae9e41a Compare August 28, 2026 09:05

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ae9e41a. Configure here.

Comment thread packages/wasm/src/index.ts
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@andreiborza
andreiborza force-pushed the ab/wasm-firefox-fallback branch from ae9e41a to a29180e Compare August 31, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant