Skip to content

feat(httpx): Migrate to span first #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericapisani wants to merge 6 commits into
base: master
Choose a base branch
from
+729 −139

Update tests. Forgot to add matching checks in other client

9d2546f
Select commit
Loading
Failed to load commit list.
Open

feat(httpx): Migrate to span first #6084

Update tests. Forgot to add matching checks in other client
9d2546f
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Apr 17, 2026 in 7m 26s

1 issue

Low

URL attributes lost on StreamedSpan when HTTP request raises exception - `sentry_sdk/integrations/httpx.py:75-103`

In the span streaming path, URL-related attributes (url.full, url.query, url.fragment) are collected in a local attributes dict but only set on the span via set_attributes() at line 103, after real_send() completes. If real_send() raises an exception, these attributes are never set on the span. In contrast, the legacy path sets these attributes (lines 119-123) before calling real_send() (line 141), ensuring URL context is preserved even on failed requests.

4 skills analyzed
Skill Findings Duration Cost
code-review 0 3m 50s $3.43
find-bugs 1 7m 23s $6.72
skill-scanner 0 3m 10s $1.32
security-review 0 3m 50s $1.35

Duration: 18m 13s · Tokens: 6.2M in / 61.4k out · Cost: $12.83 (+extraction: $0.01)

View more details on @sentry/warden